method/Class QueryFactory is deprecated [#2894218]

Comment	File	Size	Author
#3	2894218-latest-patch.patch	3.01 KB	chaitanya17
#2	2894218-patch.patch	5.4 KB	chaitanya17

Comment #1

12 July 2017 at 13:19

chaitanya17 created an issue. See original summary.

Log in or register to post comments

Comment #2

chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented 12 July 2017 at 13:22

Assigned:	chaitanya17	» Unassigned
Status:	Active	» Needs review

File	Size
2894218-patch.patch	5.4 KB

Please check attached working patch.

Log in or register to post comments

Comment #3

chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented 12 July 2017 at 14:56

File	Size
2894218-latest-patch.patch	3.01 KB

1 file was hidden/shown/deleted

File	Size
2894218-patch.patch	5.4 KB

Please check latest attached working patch.

Log in or register to post comments

Comment #4

imyaro CreditAttribution: imyaro at DrupalJedi commented 20 September 2017 at 09:48

Status:

Needs review

» Needs work

+++ b/modules/crm_core_match/src/Plugin/crm_core_match/field/FieldHandlerBase.php
@@ -54,19 +54,19 @@
   /**
    * A Contact query object.
    *
-   * @var \Drupal\Core\Entity\Query\QueryFactory
+   * @var \Drupal\Core\Entity\EntityTypeManager
    */
-  protected $queryFactory;
+  protected $entityTypeManager;

Seems old comment left by mistake.

+++ b/modules/crm_core_match/src/Plugin/crm_core_match/field/FieldHandlerBase.php
@@ -149,7 +149,7 @@
+    $query = $this->entityTypeManager->getStorage('crm_core_individual')->getQuery();

+++ b/modules/crm_core_match/src/Plugin/crm_core_match/field/NameFieldHandler.php
@@ -69,7 +69,7 @@
+      $query = $this->entityTypeManager->getStorage('crm_core_individual')->getQuery();

Probably if will be better to pass storage itself instead of the entity_type.manager?

As for me - needs work.

Log in or register to post comments

Comment #5

RoSk0

he/him

Russian

Wellington

CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented 4 December 2017 at 01:26

Component:

Code

» CRM Core Match

Log in or register to post comments

Comment #6

4 May 2019 at 14:05

grahl committed 426fae9 on 8.x-1.x authored by chaitanya17

Issue #2894218 by chaitanya17, zvse: method/Class QueryFactory is...

Log in or register to post comments

Comment #7

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 4 May 2019 at 14:05

Status:

Needs work

» Fixed

Kept it at the type manager instead of storage since the overhead was minimal. Updated the comment and relaxed the constructor to rely on EntityTypeManagerInterface.