Problem/Motivation

#2659100: Allow run-tests.sh to run just the javascript Functional tests added testGetPhpunitTestSuite() to TestInfoParsingTest.

Only it didn't, actually, because it was added to the end of one of the mock test classes used by that test. An easy mistake to make.

This means the test method is never run, because it's not on the test class.

Proposed resolution

Move testGetPhpunitTestSuite() to the test class.

Also change the name of TestInfoParsingTest to TestDiscoveryTest, because we're not only testing info parsing.

Other minor cleanups.

Note that these changes are in the patches of #2863055: Move TestDiscovery out of simpletest module, minimize dependencies

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2893371_2.patch2.49 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Needs review
FileSize
2893371_2.patch2.49 KB

The patch.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Needs review » Reviewed & tested by the community

Heh diff makes it look like we are moving TestTestDiscovery, looking at the applied patch made it make more sense.

Running just testGetPhpunitTestSuite
Time: 605 ms, Memory: 6.00MB

OK (11 tests, 11 assertions)

So with this patch we should add 11 tests to the total tests run

Current HEAD: 21,693 pass
With patch: 21,704 pass

So that checks out nicely.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: TestInfoParsingTest is broken » Several methods theoretically added to TestInfoParsingTest were actually not

  • Gábor Hojtsy committed f8fda3d on 8.3.x 
    Issue #2893371 by Mile23: Several methods theoretically added to...

  • Gábor Hojtsy committed c128b01 on 8.4.x 
    Issue #2893371 by Mile23: Several methods theoretically added to...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Makes sense, looks good. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.