Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This may be a "meta" issue, but just wanted to get this in while I'm thinking about it. So far this theme has mostly focused on the "chunks" of Drupal - ie, pages, regions, blocks, menus, etc. But we also need to give some love to the "blobs" - ie, whatever users put into content via CKEditor. A few general ideas:
- We should get the "Styles" dropdown in CKEditor to include common element styles, like buttons.
- We should also implement "templates" in CKEditor editor to help kick off more complex things like hero-callouts.
- While we're at it, we should make sure that the USWDS stylesheet is loaded in CKEditor.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | uswds-d8-ckeditor-styles-2893005-4.patch | 553 bytes | brockfanning |
| #4 | uswds-d7-ckeditor-styles-2893005-4.patch | 1.4 KB | brockfanning |
Comments
Comment #2
brockfanning CreditAttribution: brockfanning commentedLooking through the standards for things we should support. Here are some I've seen so far:
Styles for
<a>tags:Styles for
<table>tags:Styles for
<p>tags:Still thinking about the mechanism for adding "templates", for things like information alerts, and hero callouts. I'm leaning towards some sort of Drupal entity-based approach, like embedded blocks, panels, paragraphs, etc., but need to investigate more.
Comment #3
brockfanning CreditAttribution: brockfanning commentedFocusing this issue on styles, while the "template" approach is mulled over.
Comment #4
brockfanning CreditAttribution: brockfanning commentedIt looks like the way of getting CKEditor styles is totally different in D8 vs D7. I'm attaching a code change as a patch for both versions, but each will also require a manual configuration change. These are detailed below, and we'll need to add a note to the project page:
D7: Assuming the use of the CKEditor module the attached patch will add some new entries into the "Styles" dropdown. In order to load the USWDS styles in the WYSIWYG though, the CKEditor "profile" will need to be edited to set "Use theme CSS" under the "Editor CSS" section.
D8: The attached patch will make sure the USWDS styles get loaded in the WYSIWYG, but in order to add entries to the "Styles" dropdown, something similar to the following needs to be added to the text format configuration in the "Styles dropdown" section:
Comment #6
brockfanning CreditAttribution: brockfanning commented