I found three migrations that don't have a label and the label is used by the upgrade form, MigrateUpgradeForm.php. Let's add those labels.

CommentFileSizeAuthor
#13 interdiff.txt852 bytesquietone
#13 2889443-12.patch3.02 KBquietone
#8 interdiff-2-8.txt1.64 KBquietone
#8 2889443-8-test-only.patch1.82 KBquietone
#8 2889443-8.patch3.06 KBquietone
#5 interdiff.txt2.01 KBquietone
#5 2889443-5.patch3.43 KBquietone
#5 2889443-5-test-only.patch2.19 KBquietone
#2 2889443-2.patch1.24 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Active » Needs review
FileSize
2889443-2.patch1.24 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

Great catch.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Issue tags: +migrate-d7-d8
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
FileSize
2889443-5-test-only.patch2.19 KB
2889443-5.patch3.43 KB
interdiff.txt2.01 KB

It occurred to me that we should have a test to prevent migrations without labels. And here it is.

The last submitted patch, 5: 2889443-5-test-only.patch, failed testing. View results

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2889443-5.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review
FileSize
2889443-8.patch3.06 KB
2889443-8-test-only.patch1.82 KB
interdiff-2-8.txt1.64 KB

Wow that was the wrong patch. Let's try again.

Status: Needs review » Needs work

The last submitted patch, 8: 2889443-8-test-only.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review

Setting to Needs review.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Status: Needs review » Needs work

This looks good.
One small thing, those comments should be updated to say something about testing the labels.

+++ b/core/modules/migrate_drupal_ui/tests/src/Kernel/MigrationLabelExistTest.php
@@ -0,0 +1,40 @@
+ * Tests that modules exist for all source and destination plugins.
...
+   * Tests that modules exist for all source and destination plugins.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Needs work » Needs review
FileSize
2889443-12.patch3.02 KB
interdiff.txt852 bytes

Thanks maxocub, I've been doing too many copy/paste errors lately.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Status: Needs review » Reviewed & tested by the community

Thanks, perfect !

  • catch committed 81bb46e on 8.5.x 
    Issue #2889443 by quietone: Some migrations missing a label

  • catch committed d0c3da5 on 8.4.x 
    Issue #2889443 by quietone: Some migrations missing a label

(cherry...

catch credited catch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.3.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.