Follow-up to #2737805: Convert web tests to browser tests for forum module

Convert ForumIntegrationTest web tests to browser tests for forum module

Child of #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)

CommentFileSizeAuthor
#2 2889353.patch1.14 KBnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Active » Needs review
FileSize
2889353.patch1.14 KB

Here we go

$ ../vendor/bin/phpunit modules/forum/tests/src/Functional/Views/ForumIntegrationTest.php 
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\forum\Functional\Views\ForumIntegrationTest
.

Time: 3.84 minutes, Memory: 6.00MB

OK (1 test, 6 assertions)
Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at Dx Experts commented
Status: Needs review » Reviewed & tested by the community

Nice find!

Nothing else left in the forum module, so the scope of one issue is right here.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Needs review 
+++ b/core/modules/forum/tests/src/Functional/Views/ForumIntegrationTest.php
@@ -28,8 +28,8 @@ class ForumIntegrationTest extends ViewTestBase {
-  protected function setUp() {
-    parent::setUp();
+  protected function setUp($import_test_views = TRUE) {
+    parent::setUp($import_test_views);

Why do we need these added? They were not there before.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented

To fix the warning b/c ViewTestBase::setup requires the argument $import_test_views

//Naveen

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at Dx Experts commented
Status: Needs review » Reviewed & tested by the community

The child class setUp() needs to match the parent, so the change is correct.

  • Gábor Hojtsy committed 9776dd1 on 8.3.x 
    Issue #2889353 by naveenvalecha, Lendude: Convert ForumIntegrationTest...

  • Gábor Hojtsy committed 5a9de19 on 8.4.x 
    Issue #2889353 by naveenvalecha, Lendude: Convert ForumIntegrationTest...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Right, thanks! Committed :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.