Incorrect filename in INSTALL doc [#2888296]

core/INSTALL.txt provides a command to copy files from the unpacked distribution into a base directory for your website. It lists drupal-x-y-z/.eslintrc as a file to move, but the actual filename is "eslintrc.json".

Comment	File	Size	Author
#5	incorrect_filename_2888296.patch	839 bytes	Dinesh18
#5	8.4.x: PHP 5.6 & MySQL 5.5 22,025 pass
#4	Patch applied on 8.3.png	6.34 KB	Dinesh18
#4	Applied patch on 8.4.png	6.24 KB	Dinesh18
#2	incorrect_filename_2888296.patch	839 bytes	jalpesh
#2	8.3.x: PHP 5.6 & MySQL 5.5 21,764 pass 8.4.x: PHP 5.6 & MySQL 5.5 22,025 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 June 2017 at 03:15

kthompso created an issue. See original summary.

Comment #2

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented 22 June 2017 at 09:23

Status:

Active

» Needs review

File

Size

incorrect_filename_2888296.patch

839 bytes

8.3.x:
PHP 5.6 & MySQL 5.5 21,764 pass

8.4.x:
PHP 5.6 & MySQL 5.5 22,025 pass

Here you go with patch.

Comment #3

cilefen CreditAttribution: cilefen commented 22 June 2017 at 14:21

Category:

Task

» Bug report

Comment #4

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented 23 June 2017 at 14:13

Version:

8.3.4

» 8.4.x-dev

File	Size
Applied patch on 8.4.png	6.24 KB
Patch applied on 8.3.png	6.34 KB

I have tested the patch and it seems to be cleanly applied on 8.3.x and 8.4.x
Attaching the git bash screengrab.
It seems the files which you were describing is .eslintrc.json and the patch corrects the file name.
Changing the status to RTBC.
For 8.4.x automatic testing, re-uploading the same patch

Comment #5

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented 23 June 2017 at 14:16

File	Size
incorrect_filename_2888296.patch	839 bytes
8.4.x: PHP 5.6 & MySQL 5.5 22,025 pass

Re-uploaded the same patch

Comment #6

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented 23 June 2017 at 17:18

Status:

Needs review

» Reviewed & tested by the community

Changing the status to RTBC, the patch cleanly applied to 8.4.x.
I think we are good to go. :)

Comment #7

cilefen CreditAttribution: cilefen commented 23 June 2017 at 18:40

I am updating credit.

Comment #8

23 June 2017 at 18:43

cilefen committed 5de007b on 8.4.x

Issue #2888296 by jalpesh: Incorrect filename in INSTALL doc

Comment #9

23 June 2017 at 18:43

cilefen committed 1a765c5 on 8.3.x

Issue #2888296 by jalpesh: Incorrect filename in INSTALL doc

(cherry...

Comment #10

cilefen CreditAttribution: cilefen commented 23 June 2017 at 18:44

Version:	8.4.x-dev	» 8.3.x-dev
Status:	Reviewed & tested by the community	» Fixed

Committed 5de007b on 8.4.x and cherry-picked to 8.3.x as 1a765c58a because this is a documentation improvement.

Thanks @jalpesh for the patch and @Dinesh18 for reviewing! A few words on procedure: We don't need confirmation that the patch applies, since the automated testing infrastructure tells us that. Screenshots of the patch applied to the codebase are not needed in any issue.

Is someone interested in looking into whether core/UPDATE.txt mentions all the correct files to copy when updating Drupal, then finding or opening an issue? And for that matter, does INSTALL.txt mention all relevant files?