There were some issues with coding standards, so I created a patch to fix some issues found on coder. Left some issues like "Type hint 'array' missing" and "Missing parameter type". If you find those issues to be critical, just change this Issue to "needs work".

Pareview Coder Issues

CommentFileSizeAuthor
#5 interdiff.txt3.15 KBYago Elias
#5 coding_standards-2888112-5.patch4.42 KBYago Elias
#2 coding_standards-2888112-2.patch4.71 KBAlgarte
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Algarte created an issue. See original summary.

Algarte’s picture

Algarte CreditAttribution: Algarte at CI&T commented
FileSize
coding_standards-2888112-2.patch4.71 KB
Algarte’s picture

Algarte CreditAttribution: Algarte at CI&T commented
Assigned: Algarte » Unassigned
Algarte’s picture

Algarte CreditAttribution: Algarte at CI&T commented
Status: Active » Needs review
Yago Elias’s picture

Yago Elias CreditAttribution: Yago Elias as a volunteer and at CI&T commented
FileSize
coding_standards-2888112-5.patch4.42 KB
interdiff.txt3.15 KB

Hi @algaerte! Just some small fixes!

Algarte’s picture

Algarte CreditAttribution: Algarte at CI&T commented
Status: Needs review » Reviewed & tested by the community

Thank you @Yago Elias for pointing out those issues. I realized that i don't need to fix all warnings and errors.

Some of them are false positives or does not make sense to fix.
I tested your patch and it worked fine.

Thanks once again.

pjcdawkins’s picture

pjcdawkins CreditAttribution: pjcdawkins commented
Category: Bug report » Task
Priority: Normal » Minor
Status: Reviewed & tested by the community » Postponed

I can run some clean-up before the next release, but it's not going to be following an automatic checker.

  1. +++ b/includes/OpenIDConnectClientInterface.class.php
@@ -5,6 +5,9 @@
+/**
+ * Interface OpenIDConnectClientInterface.
+ */
 interface OpenIDConnectClientInterface {

    This docblock might be following the letter of a coding standard, but it's not an improvement. 

  2. +++ b/includes/OpenIDConnectClientInterface.class.php
@@ -98,7 +101,7 @@ interface OpenIDConnectClientInterface {
+   * @return array|false

    In Drupal's coding standards, "constants" including TRUE, FALSE and NULL should be in uppercase, so this fix is invalid (see https://www.drupal.org/docs/develop/standards/coding-standards).

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Postponed » Active

Found this issue after fixing the code standards for Drupal 7.

  • jcnventura authored 6680eaf on 7.x-1.x 
    Issue #2888112 by Yago Elias, Algarte, jcnventura: Coding Standards
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.