Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In working on #2766491: Update status should indicate whether installed contributed projects receive security coverage, I used the admin_block
theme, which comes with a light grey background. For that issue, more-flexible background options are needed.
Comment | File | Size | Author |
---|---|---|---|
#7 | 2887860.patch | 3.01 KB | drumm |
Comments
Comment #2
drummThis patch adds attributes array processing with
template_preprocess_admin_block
and movescolors.css
later in the cascade so its background takes precedence.Comment #4
drummThis currently applies cleanly to 8.5.x.
Comment #5
star-szrThanks @drumm, overall looks very good!
Minor: missing data type.
For these we can use the pattern established in Classy like so:
Maybe move this to the 'theme' group for the added specificity?
Comment #6
star-szrOn second thought, we could probably just do
$variables['attributes']
here, then we wouldn't need the new Attribute() part and the template would just print attributes.The calling code would then move the attributes up to the top level in its own hash key.
To do this, I believe we'd need to update the hook_theme definition to add
attributes => []
to variables.Comment #7
drummThe attached patch fixes all the suggestions and is working well. Thanks for the review!
Comment #8
star-szrLooks great, and I tested along with the latest patch in #2766491: Update status should indicate whether installed contributed projects receive security coverage and it works well. The markup for existing uses of this template remains the same so this is a safe change to make in the Stable theme. Thanks!
Comment #9
larowlanCommitted aaa668a and pushed to 8.5.x. Thanks!