Problem/Motivation

I think for some applications, we only want a few resources enabled. See the following example:

Proposed resolution

Add an option to only display enabled resources in the UI.

CommentFileSizeAuthor
#15 jsonapi_extras-2886887-15.patch3.23 KBlogickal
#13 Selection_497.png60.33 KBdagmar
#11 interdiff-2886887-5-11.txt771 bytesdagmar
#11 2886887-11.patch3.24 KBdagmar
#7 resources_fieldsets.png83.65 KBdagmar
#7 resources_fieldsets_collapsed.png46.41 KBdagmar
#5 2886887-5.patch3.46 KBdagmar
#2 2886887-2.patch3.32 KBdagmar
hide_resources.png90.36 KBdagmar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dagmar created an issue. See original summary.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
Title: Hide disabled items » Allow to hide disabled resources
FileSize
2886887-2.patch3.32 KB

Here is the patch.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
Status: Active » Needs review
shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented

What if we moved disabled resources inside a collapsed fieldset? Like Views UI does it.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
FileSize
2886887-5.patch3.46 KB

Good idea. Here is the patch.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

@dagmar can you add a screenshot?

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
Issue summary: View changes
FileSize
resources_fieldsets_collapsed.png46.41 KB
resources_fieldsets.png83.65 KB

Of course :)

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
Title: Allow to hide disabled resources » Separate enabled from disabled resources
dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
Status: Needs review » Needs work

New resources (not overridden) are hidden in both fieldsets.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

New resources (not overridden) are hidden in both fieldsets.

Should they be a separate fieldset instead?

Also, is the search still working as expected?

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
Status: Needs work » Needs review
FileSize
2886887-11.patch3.24 KB
interdiff-2886887-5-11.txt771 bytes

Yes the search works for both fieldsets.

This solves the problem with not overridden resources.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

This solves the problem with not overridden resources.

How did you solve it? can you post a screenshot?

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
FileSize
Selection_497.png60.33 KB

Here is the screenshot.

logickal’s picture

logickal CreditAttribution: logickal at The Weather Company commented

Just chiming in to say that I love this idea, and the screenshots look great. I'm going to try the patch on our stack this evening and test things out.

logickal’s picture

logickal CreditAttribution: logickal at The Weather Company commented
FileSize
jsonapi_extras-2886887-15.patch3.23 KB

Patch is throwing:
Notice: Undefined variable: status in Drupal\jsonapi_extras\JsonapiResourceConfigListBuilder->render() (line 92 of modules/contrib/jsonapi_extras/src/JsonapiResourceConfigListBuilder.php).

Sure enough, the filter is looking for $status, but not defined. Attached patch replaces the variable with a string, and the filter functionality works as I would expect it to.

Besides that, this is a great UI improvement!

  • e0ipso committed 3f3d8f4 on 8.x-1.x authored by logickal 
    feat(UI): Separate enabled from disabled resources (#2886887 by dagmar,...

  • e0ipso committed 9a67e44 on 8.x-1.x authored by dagmar 
    feat(UI): Separate enabled from disabled resources (#2886887 by dagmar,...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

Thanks for the patch! I did not review the code (for API is hard to review). I did some smoke testing instead.

I made 2 commits to give authorship to the both of you. You rock!

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented

Thanks! Should we move this to fixed then?

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.