On line 72 of: core/modules/user/src/AccountForm.php it sets:
$admin = $user->hasPermission('administer users');
then it uses it in several places, but misses opportunity in 2 other places, and just calls the hasPermisison() method again instead.

Patch in next comment. This is against 8.3.x, but I can also roll one for 8.4.x if I need to.

CommentFileSizeAuthor
#2 user-accountform-use-admin-var-2884141-2.patch1.25 KBjwjoshuawalker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drastik created an issue. See original summary.

jwjoshuawalker’s picture

jwjoshuawalker CreditAttribution: jwjoshuawalker as a volunteer commented
Status: Active » Needs review
FileSize
user-accountform-use-admin-var-2884141-2.patch1.25 KB

Patch attached. Let me know if I should do anything else.

arifkhn46’s picture

arifkhn46 CreditAttribution: arifkhn46 as a volunteer commented

I reviewed the patch it is working good.

arifkhn46’s picture

arifkhn46 CreditAttribution: arifkhn46 as a volunteer commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.3.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x, thanks!

  • catch committed da86c03 on 8.4.x 
    Issue #2884141 by drastik: User AccountForm.php sets $admin var but...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.