Obsolete argument for hasPermission in node_node_access()

I noticed this error as well. The patch looks good to me and tests are green :)

I tried to think of any way this might break something. The only scenario I could come up with involved swapping out the entity access checker to call a different implementation of AccountInterface::hasPermission() that also did a func_get_args() (because an added parameter in the method signature would break the contract of the interface).

That's pretty scifi, so I think we're fine.

I did find one more instance of this error though:
core/modules/node/tests/modules/node_access_test/node_access_test.module: if ($op == 'view' && $account->hasPermission('node test view', $account)) {

Tagging novice for that additional usage.

Thanks, looks like you accidently added an unrelated change though?

Here is updated patch

Patch on #12 looks fine and it works for me!

Thanks. There are about 3 different issues touching this function, it has more weirdness/bugs than lines of code. Lets see if we can get this one in this time ;)

Committed and pushed 269c716d1d to 8.7.x and 3e22551b1d to 8.6.x. Thanks!

I found one more using a regex....

diff --git a/core/modules/node/tests/src/Functional/NodeRevisionPermissionsTest.php b/core/modules/node/tests/src/Functional/NodeRevisionPermissionsTest.php
index ed632a7e92..d0aa88efbb 100644
--- a/core/modules/node/tests/src/Functional/NodeRevisionPermissionsTest.php
+++ b/core/modules/node/tests/src/Functional/NodeRevisionPermissionsTest.php
@@ -153,7 +153,7 @@ public function testNodeRevisionAccessPerType() {
     foreach ($permutations as $case) {
       // Skip this test if there are no revisions for the node.
       if (!($revision->isDefaultRevision() && (db_query('SELECT COUNT(vid) FROM {node_field_revision} WHERE nid = :nid', [':nid' => $revision->id()])->fetchField() == 1 || $case['op'] == 'update' || $case['op'] == 'delete'))) {
-        if (!empty($case['account']->is_admin) || $case['account']->hasPermission($this->typeMap[$case['op']], $case['account'])) {
+        if (!empty($case['account']->is_admin) || $case['account']->hasPermission($this->typeMap[$case['op']])) {
           $this->assertTrue($node_revision_access->checkAccess($revision, $case['account'], $case['op']), "{$this->typeMap[$case['op']]} granted.");
         }
         else {

Fixed on commit. I ran the test locally.