Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In working on #2882729: In off-canvas block form hide Title input unless it will be displayed and change label to Block Title I figure out that ever we are calling \Drupal\FunctionalJavascriptTests\JSWebAssert::waitForElementVisible
We don't actually check if the element is returned.
So the current wait do give the element time to appear but they don't actually cause a failure if the element doesn't appear.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2883483-2.patch | 5.05 KB | tedbow |
Comments
Comment #2
tedbowCreated assertElementVisibleAfterWait() and replaced all calls to JSWebAssert::waitForElementVisible with it.
Comment #3
tedbowComment #4
Wim LeersLooks like an improvement! Strengthens test coverage, and reduces chance of mysterious test failures. What's not to like?
Nit: s/Assert/Asserts/
Comment #5
webchickNice clean-up. Fixed the nit on commit. (My fantastic collection of Drupal-related poetry is due out any day now...)
Committed and pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!
Comment #9
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)