Problem/Motivation

To avoid installing module without libraries I suggest adding hook_requirements() in the .install file. This will allow being sure that module will be installed only in a case when library added. Without the library, this module does not make sense to install.

Proposed resolution

Add hook_requirements().

Remaining tasks

Review patch.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#6 colorbutton-hook-requirements-2881819-6.patch1003 bytesddrozdik
#4 colorbutton-hook-requirements-2881819.patch984 bytesddrozdik
#2 colorbutton-hook-requirements-2881819.patch985 bytesddrozdik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ddrozdik created an issue. See original summary.

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW for Open Y commented
Status: Active » Needs review
FileSize
colorbutton-hook-requirements-2881819.patch985 bytes

Here is a patch.

hamrant’s picture

hamrant CreditAttribution: hamrant at DEWEB Studio, Drupal Ukraine Community, FFW, Open Y for Drupal Ukraine Community commented

Looks good, one minor fix:

+++ b/colorbutton.install
@@ -0,0 +1,29 @@
+       Download the plugin from http://ckeditor.com/addon/colorbutton at least ¶

Please delete whitespace on 23 line.

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW for Open Y commented
FileSize
colorbutton-hook-requirements-2881819.patch984 bytes

Here is updated patch with removed whitespace on 23 line.

hamrant’s picture

hamrant CreditAttribution: hamrant at DEWEB Studio, Drupal Ukraine Community, FFW, Open Y for Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community
ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW, Drupal Ukraine Community for Open Y commented
Status: Reviewed & tested by the community » Needs review
FileSize
colorbutton-hook-requirements-2881819-6.patch1003 bytes

I found an issue with the latest patсh. Here is update version.

  • ddrozdik committed d5eb605 on 8.x-1.x 
    Issue #2881819 by ddrozdik: Check for missing library in...
ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW, Drupal Ukraine Community for Open Y commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.