Problem/Motivation

Blocker to #2865971: Use stylelint as opposed to csslint in core

We've got lots of whitespace issues in CSS were we are not adhering to https://www.drupal.org/docs/develop/standards/css/css-coding-standards

Proposed resolution

Fix whitespace issues in CSS using #2865971: Use stylelint as opposed to csslint in core to detect it.

To review the patch use git diff --color-words --word-diff-regex=.. It makes it easy to see the scope of the changes are only whitespace.

Remaining tasks

This is split off from #2865971: Use stylelint as opposed to csslint in core - the very minor change is that 

  /* border-top: 1px solid #bfbfbf; */

Is fixed to add spaces so that it passes the ruleset rather than removed.

User interface changes

None

API changes

None

CommentFileSizeAuthor
#2 2878548-2.patch39.71 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Reviewed & tested by the community
FileSize
2878548-2.patch39.71 KB

In discussion with @xjm as this is part of an rtbc patch it can go straight to rtbc.

alexpott credited Cottser.

alexpott credited droplet.

alexpott credited idebr.

alexpott credited joelpittet.

alexpott credited martin107.

alexpott credited xjm.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

Adding credit from #2865971: Use stylelint as opposed to csslint in core

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Related issues: +#2844719: CSS indented with 4 spaces should be 2 spaces
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes

  • cilefen committed ef1db63 on 8.4.x 
    Issue #2878548 by alexpott, droplet, Cottser, idebr, joelpittet, xjm,...
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Reviewed & tested by the community » Fixed

Committed ef1db63 and pushed to 8.4.x. Thanks!

This completely satisfies stylelint with the patch from #2865971: Use stylelint as opposed to csslint in core, and it's easier to read. Go standards!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.