This from cilefen
https://www.drupal.org/node/2205673#comment-12077914
git grep -e '@deprecated.*before Drupal 8'
core/modules/system/src/Tests/Entity/EntityUnitTestBase.php: * @deprecated in Drupal 8.1.x, will be removed before Drupal 8.2.x. Use
core/tests/Drupal/FunctionalJavascriptTests/JavascriptTestBase.php: * @deprecated in Drupal 8.1.x, will be removed before Drupal 8.3.x. Use
core/tests/Drupal/FunctionalJavascriptTests/JavascriptTestBase.php: * @deprecated in Drupal 8.1.x, will be removed before Drupal 8.3.x. Use
core/tests/Drupal/KernelTests/KernelTestBase.php: * @deprecated in Drupal 8.0.x, will be removed before Drupal 8.2.0.
My conclusion we have stuff to delete in 8.4.x
Comment | File | Size | Author |
---|---|---|---|
#11 | 2877030-11.patch | 3.48 KB | c.nish2k3 |
#8 | 2877030-8.patch | 3.5 KB | c.nish2k3 |
#6 | 2877030-6.patch | 2.5 KB | gaurav.kapoor |
#2 | removal-2877030-2.patch | 10.49 KB | martin107 |
Comments
Comment #2
martin107 CreditAttribution: martin107 as a volunteer commentedthe patch
Comment #3
andypostThat's strange that code removed begore 9.x but as IS said
Comment #4
alexpottWe should update these deprecation notices. We agreed that we wouldn't do this. We have the chance of breaking tests if we do this. And that's wrong.
Comment #5
Mile23So mark them for removal before 8.5.x or before 9.0.0? Guessing 9.0.0. :-)
Also, they need @trigger_error() as per https://www.drupal.org/core/deprecation
Comment #6
gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commentedUpdated deprecation notices accordingly.Should @trigger_error be added to every method or only before the class declaration.
Comment #7
Mile23Based on https://www.drupal.org/core/deprecation, we can figure out that
EntityUnitTestBase
should@trigger_error()
right after the namespace declaration.The methods of
JavascriptTestBase
should get@trigger_error()
at the end of execution in the deprecated methods.And
Drupal\KernelTests\KernelTestBase::__get()
already triggers errors and throws exceptions for its special cases, because it's trying to tell you not to access those properties. So don't add another one.We might well see some failed tests based on these changes.
Comment #8
c.nish2k3 CreditAttribution: c.nish2k3 as a volunteer commentedUpdated patch with comments from #7
Comment #9
c.nish2k3 CreditAttribution: c.nish2k3 as a volunteer commentedComment #10
dawehnerWe don't need newline for PHP code. Do you mind moving it into one line?
Comment #11
c.nish2k3 CreditAttribution: c.nish2k3 as a volunteer commentedUpdated patch. Moved them to one line.
Comment #14
borisson_The problem from #10 was fixed in #11.
Comment #15
alexpottI checked for change records for these changes - they don't exist. Since they are so old I don't think adding them now is that useful however have deprecation notices that correctly state that these things will be removed in Drupal 9 is.
Committed and pushed 2defaa4e44 to 8.6.x and c5df1de53b to 8.5.x. Thanks!
Since this is tests only backported to 8.5.x
Gave review credit to @dawehner and @Mile23