Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Here are the trivial fixes for core components composer.json files.
The issue to prevent regressions is #2867960: Merge Component composer.json files to account for them during build, but that will take time, while the fixes here are both trivial and important for subtree split users. There's also #2876669: Fix dependency version requirement declarations in components to fix the symfony dependencies for 8.4.x.
Comment | File | Size | Author |
---|---|---|---|
#19 | fix_trivial_core-2876725-19.patch | 1.39 KB | Mixologic |
#16 | 2867960-16.patch | 2.63 KB | Eric_A |
#11 | 2867960-24-drupal-8.3_0-11.patch | 2.63 KB | pk188 |
#9 | 2867960-24-drupal-8.3_0-9.patch | 2.63 KB | pk188 |
2867960-24-drupal-8.3.patch | 2.63 KB | Eric_A | |
Comments
Comment #2
Eric_A CreditAttribution: Eric_A commentedComment #3
Eric_A CreditAttribution: Eric_A commentedComment #4
dsnopekIs anyone hosting a subtree split somewhere that includes these changes?
Comment #5
dawehnerThe DA has claimed the namespace, in order to actually host those, see https://packagist.org/packages/drupal/core-annotation and so on and forth.
Comment #6
Eric_A CreditAttribution: Eric_A commentedAlso, @Mile23 started this:
From #2867960-62: Merge Component composer.json files to account for them during build
Comment #7
dsnopekWhat I meant is if someone had made their own subtree split with this patch so that you could put the alternate repos in "repositories" in your composer.json. Personally, I ended up making my own fork of drupal/core-annotations so that I could successfully install it in a non-Drupal project:
https://github.com/dsnopek/core-annotation/tree/issue-2876725
Anyway, I have to believe I'm not the only person trying to use that component outside of Drupal, so I was wondering if someone had already done it. :-)
Comment #8
joshmillerWhy are we adding a dependency? Does this just need a re-roll without it?
Comment #9
pk188 CreditAttribution: pk188 at OpenSense Labs commentedRe rolled as patch failed to apply. Not sure about #8.
Comment #11
pk188 CreditAttribution: pk188 at OpenSense Labs commentedComment #13
Eric_A CreditAttribution: Eric_A commented@pk188, let's only test against the branch each patch is targeted at :-)
@joshmiller, this hunk just fixes missing test coverage of one composer.json file. Whenever a component is added, we should expand this test, but obviously this is easily missed. We don't have a test to detect that we're not testing all composer.json files.
Comment #14
Eric_A CreditAttribution: Eric_A commentedNote that differences between the branches is because #2769841: Prefer caret over tilde in composer.json went into 8.4.x.
Hunks that fix package names should not change the operator, i.e. the 8.4.x patch should now not accidentally change caret operators to tilde.
Comment #16
Eric_A CreditAttribution: Eric_A commentedIt is actually becoming pretty embarrassing, such naming bugs, and then the obvious version conflict with core/composer.lock.
Comment #17
Eric_A CreditAttribution: Eric_A commentedComment #18
alexpottThis should be ^1.2.*
Perhaps we need a test to ensure that these match what is in core/composer.json?
Comment #19
MixologicThis patch is still fixing too many things that could have tests. If we pare it down to just the misspellings/wrong names, we can unblock drupalci's use of these components.
Comment #20
Eric_A CreditAttribution: Eric_A commentedYes, let's do just the name fixing, here.
Comment #21
alexpottI discussed this with @catch and we agreed that this could go into 8.4.x as well as 8.5.x
Committed and pushed 1188f1c to 8.5.x and b70d217 to 8.4.x. Thanks!
We need to open follow-ups for the other issues around consistent version requirements and test coverage.
Comment #24
dsnopekHuzzah! Thanks, Everyone!
Comment #25
Eric_A CreditAttribution: Eric_A commentedI've created:
#2913459: drupal/core-class-finder missing in ComposerIntegrationTest
#2913460: drupal/core-class-finder missing from replace section
Comment #26
Eric_A CreditAttribution: Eric_A commentedHere's the issue for version conflicts:
#2913570: Version conflicts between core and embedded components requirements