User Homepage module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#4 short_array_syntax-2875701-4.patch12.79 KBslv_
#3 user_homepage_array_search_results.png117.8 KBdhruveshdtripathi
#2 short_array_syntax-2875701-2.patch11.43 KBMunavijayalakshmi

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
StatusFileSize
new short_array_syntax-2875701-2.patch11.43 KB
dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new user_homepage_array_search_results.png117.8 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 27 array declarations, after applying patch there is 1. That 1 array is in_array.

Good work!

slv_’s picture

slv_ commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new short_array_syntax-2875701-4.patch12.79 KB

New patch that makes the test pass again, removes usage of a couple deprecated functions, and applies the changes from #2.

  • a758d22 committed on 8.x-1.x 
    Issue #2875701 by Munavijayalakshmi, slv_, dhruveshdtripathi: Convert...
slv_’s picture

slv_ commented
Status: Needs review » Fixed

Commited to 8.x-1.x-dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.