Add Change record to @deprecated for Domain::Config Language Negotations

Hey @maryedith, I reviewed patch file. Below are some findings that should be corrected -

1. +++ b/core/modules/language/language.module
   @@ -270,6 +270,8 @@ function language_get_default_langcode($entity_type, $bundle) {
   + * @see https://www.drupal.org/node/2182661
   

   @see should be mentioned after @deprecated.

2. +++ b/core/modules/language/language.module
   @@ -299,6 +301,8 @@ function language_negotiation_url_prefixes_update() {
   + * @see https://www.drupal.org/node/2182661
   

   @see should be mentioned after @deprecated.

Thanks for the patch file.

Here is the updated patch which incorporates the #4 comments.

Hey @Dinesh18, Everything's good with your patch. Only has a trailing whitespace on line 9 which needs to be taken care of. Please remove it.

Thanks for your work. :)

Changes made according to comment #8

Thank you!

Applied the patch mentioned in #9. Resolved the trailing whitespace error.
Changing the status to RTBC.

https://www.drupal.org/node/2182661 is certainly not related to the patch that added these depreciation notices. Which patch added the depreciation notices? Does it have a change record?

language_negotiation_url_domains() and language_negotiation_url_prefixes() were deprecated in #2403229: language.negotiation configuration can have overrides bleed in which does not have a change record, though it does have an API change. However, @alexpott mentions that a CR isn't needed: #2403229-34: language.negotiation configuration can have overrides bleed in

That issue has two follow-ups that aren't finished: #2462729: Move ConfigurableLanguage hook implementations in language module to the entity #2548079: Move language negotiation prefix logic update to ConfigurableLanguage

In that case I think we need to add that change record so we can link to it and people find out what it is. We could like to the issue as well theoretically but we don'd do that in these links because change records are much easier to parse and act on.

I'm at DrupalCon vienna and I'll pick up this issue.

The change for the functions language_negotiation_url_prefixes() and language_negotiation_url_domains() happened in #2403229-31: language.negotiation configuration can have overrides bleed in and no change record was created. I'll draft a change record for this.

sorry misposted

I have created a patch to link to the new change record https://www.drupal.org/node/2912748 for the functions language_negotiation_url_prefixes() and language_negotiation_url_domains()

Thanks for everyone for work on this!

I am changing the title for this issue because as per #2873705: Add change records to all @deprecated code we need scope these types of issues by change records not by files. Please read that more issue for the complete instructions.

Luckily though both the changes in this patch do link to the same change record: https://www.drupal.org/node/2912748 (@billywardrop thanks for finding the correct one!)

Looking back at the issue related to this change record #2403229: language.negotiation configuration can have overrides bleed in and the commit for this issue http://cgit.drupalcode.org/drupal/commit/?id=52e5d45 the 2 @deprectated tags covered by this patch are the only ones added by this commit.

If there were more @deprecated tags added by this change we would want to include them in this patch even if they were not in language.module file(hence the name change). This is important because it gives reviewers and committers the confidence that we have search for @deprecated instances from this change(so they don't get forgotten).

This looks good to me!

I have also applied the patch and confirmed that there are no trailing spaces any more as mentioned by @dhruveshdtripathi in #9

That looks good to me, thanks!

Committed to 8.5.x. As a documentation improvement, this issue can be backported, but leaving RTBC against 8.4.x since we're in commit freeze for 8.4.1 at the moment. We'll cherry-pick the commit after the freeze.

It says that this patch still needs work but is already commited? What work still needs to be done to this ticket to complete it?

This was commited 4 years ago, changing to fixed.