Problem/Motivation

Currently default_content depends on rest module to get serialization_class of the entity type which is commonly getClass() method http://cgit.drupalcode.org/drupal/tree/core/modules/rest/src/Plugin/Deri...

Proposed resolution

Get rid of rest module dependency

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2874159-norest-3-full.patch13.34 KBandypost
#2 2874159-norest-2.patch4.79 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Parent issue: » #2867579: Core 8.3 compatibility
FileSize
2874159-norest-2.patch4.79 KB

Build on top of #2867579: Core 8.3 compatibility

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Active » Needs review
FileSize
2874159-norest-3-full.patch13.34 KB

commutative patch

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

looks good to me!
thanks @andypost

The last submitted patch, 2: 2874159-norest-2.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

  • larowlan committed 68c3091 on 8.x-1.x authored by andypost 
    Issue #2874159 by andypost, larowlan: Get rid of rest module dependency
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Fixed » Needs review

Looks it still needs rest somehow, got a lot of reports of import of default content

RuntimeException: Unable to determine class for field type '' found      [error]
in the 'core.base_field_override.' configuration in
.../build/core/lib/Drupal/Core/Field/FieldConfigStorageBase.php:28
Stack trace:
#0
.../build/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php(189):
Drupal\Core\Field\FieldConfigStorageBase->mapFromStorageRecords(Array,
Array)
#1
.../build/core/lib/Drupal/Core/Entity/EntityStorageBase.php(242):
Drupal\Core\Config\Entity\ConfigEntityStorage->doLoadMultiple(Array)
#2
.../build/core/lib/Drupal/Core/Entity/EntityFieldManager.php(338):
Drupal\Core\Entity\EntityStorageBase->loadMultiple(Array)
#3
.../build/core/lib/Drupal/Core/Entity/EntityFieldManager.php(298):
Drupal\Core\Entity\EntityFieldManager->buildBundleFieldDefinitions('node',
'article', Array)
#4
.../build/core/lib/Drupal/Core/Entity/EntityManager.php(145):
Drupal\Core\Entity\EntityFieldManager->getFieldDefinitions('node',
'article')
#5
.../build/core/modules/hal/src/LinkManager/RelationLinkManager.php(128):
Drupal\Core\Entity\EntityManager->getFieldDefinitions('node',
'article')
#6
.../build/core/modules/hal/src/LinkManager/RelationLinkManager.php(110):
Drupal\hal\LinkManager\RelationLinkManager->writeCache(Array)
#7
.../build/core/modules/hal/src/LinkManager/RelationLinkManager.php(83):
Drupal\hal\LinkManager\RelationLinkManager->getRelations(Array)
#8
.../build/core/modules/hal/src/LinkManager/LinkManager.php(59):
Drupal\hal\LinkManager\RelationLinkManager->getRelationInternalIds('http://drupal.o...')
#9
.../build/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php(165):
Drupal\hal\LinkManager\LinkManager->getRelationInternalIds('http://drupal.o...')
#10
.../build/vendor/symfony/serializer/Serializer.php(250):
Drupal\hal\Normalizer\ContentEntityNormalizer->denormalize(Array,
'Drupal\\taxonomy...', 'hal_json', Array)
#11
.../build/vendor/symfony/serializer/Serializer.php(160):
Symfony\Component\Serializer\Serializer->denormalizeObject(Array,
'Drupal\\taxonomy...', 'hal_json', Array)
#12
.../build/vendor/symfony/serializer/Serializer.php(118):
Symfony\Component\Serializer\Serializer->denormalize(Array,
'Drupal\\taxonomy...', 'hal_json', Array)
#13
.../build/modules/default_content/src/Importer.php(183):
Symfony\Component\Serializer\Serializer->deserialize(Array,
'Drupal\\taxonomy...', 'hal_json', Array)
#14
.../build/modules/default_content/src/Config/DefaultContentConfigSubscriber.php(41):
Drupal\default_content\Importer->importContent('custom_defaul...')
#15
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

That looks unrelated to me, sounds like you have messed up base field overrides without a field type?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Fixed

Sure, @berdir thanx a lot for pointer, issue exactly in caches field definitions

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

FYI it was caused by #2833562: Installing modules using the ConfigImporter does not work
That means dependencies resolved wrong

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#2758897: Move rest module's "link manager" services to serialization module, +#2854830: Move rest/serialization module's "link manager" services to HAL module

This was made possible by #2758897: Move rest module's "link manager" services to serialization module and #2854830: Move rest/serialization module's "link manager" services to HAL module — glad to see this being taken advantage of in contrib!