Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add all the references to the Change record: [#2831499]
For more information about the original change see: https://www.drupal.org/project/drupal/issues/2248983
Comment | File | Size | Author |
---|---|---|---|
#7 | change_record_reference-2873860-7.patch | 1.12 KB | Nikro |
Comments
Comment #3
Janec CreditAttribution: Janec commentedHi, I'm @ drupalcon Vienna and about to try to help with this issue.
Comment #4
Janec CreditAttribution: Janec commentedHi, there is only one deprecated private function. Since it is private nobody can use it outside of the class it self. The method is used only once on line 295. Is it worth documenting the necessary changes for this single usage?
Comment #5
tedbow@Janec thanks starting to this.
We don't want to create a separate issue for each file but for every change which may affect multiple files.. This
@deprecated
tag was added in #2248983: Define the revision metadata base fields in the entity annotation in order for the storage to create them only in the revision table which has 2 change record https://www.drupal.org/node/2831499 https://www.drupal.org/node/2870643If there not already an issue for this we want to make sure that all
@deprecated
tags from that issue have@see
tag pointing https://www.drupal.org/node/2831499So we would also need to change the title of this issue to reflect the change record concept not an individual file.
There are 2 commits that mention #2248983: Define the revision metadata base fields in the entity annotation in order for the storage to create them only in the revision table : http://cgit.drupalcode.org/drupal/log/?qt=grep&q=2248983
Setting back to Active because there is not a patch yet.
Comment #7
Nikro CreditAttribution: Nikro as a volunteer and for 2Toucans commentedHi,
We're working on this issue together with @mecmartini during the SprintWeekend2018.
We've analyzed the original changes in: https://www.drupal.org/project/drupal/issues/2248983 and noticed that we need to add 2 references to the change of record: [#2831499].
Patched attached below, also adjusted the title and description of the issue.
Comment #8
sk33lz CreditAttribution: sk33lz at Zivtech commentedThe #7 patch applies cleanly to 8.6.x.
Comment #9
borisson_Looks solid.
Comment #11
alexpottCrediting @time2buzzthetower for creating the issue, @tedbow for issue management and @mecmartini as according to #7 they worked on this too.
Comment #12
alexpottThis is not really required. All post updates will be cleared out during the preparation for Drupal 9 - like hook_update_N()'s. Fixed on commit.
Committed and pushed 951b4334fb to 8.6.x and 2be4ef6160 to 8.5.x. Thanks!
As docs change backported to 8.5.x.
Comment #15
Anonymous (not verified) CreditAttribution: Anonymous commented8000!!! You really are a legendary person, @alexpott!