Add Change record to @deprecated for MigrateCckFieldPluginManagerInterface.php -- line 12

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vrwired created an issue. See original summary.

heddn’s picture

Title: Add Change record to @deprecated for MigrateCckFieldPluginManagerInterface.php » Add Change record to @deprecated for MigrateCckFieldPluginManagerInterface
sorabh.v6’s picture

Status: Active » Needs work

Hey @vrwired, I downloaded patch file and tried to apply it. But its throwing error. Below is the outcome -

Checking patch core/modules/menu_link_content/src/Plugin/migrate/process/d6/LinkUri.php...
error: while searching for:
 *
 * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0. Use
 * \Drupal\menu_link_content\Plugin\migrate\process\LinkUri instead.
 */
class LinkUri extends RealLinkUri {}

error: patch failed: core/modules/menu_link_content/src/Plugin/migrate/process/d6/LinkUri.php:9
error: core/modules/menu_link_content/src/Plugin/migrate/process/d6/LinkUri.php: patch does not apply
Checking patch core/modules/migrate_drupal/src/Plugin/MigrateCckFieldPluginManagerInterface.php...

I suggest you to pull latest changes and recreate patch file.

Thanks for your work :)

jofitz’s picture

Status: Needs work » Needs review
FileSize
1002 bytes
705 bytes
  • Removed unrelated content (LinkUri.php)
  • Reinstated new line.
Dinesh18’s picture

#4 Patch doesn't seems to follow depreciation policy.
Here is an updated patch.

Mile23’s picture

Status: Needs review » Needs work

Out of scope changes in #5. We only want to add @see for change records in this issue.

jofitz’s picture

Status: Needs work » Needs review

We can simply return to the patch in #4 so setting back to Needs Review.

@Dinesh18 It may be worth checking whether there is already an issue addressing the change you wish to make (in #5), if not create a new issue and attach your patch to that.

Dinesh18’s picture

In #5, I resolved a nitpick present in #4...

  * @deprecated in Drupal 8.3.x, to be removed before Drupal 9.0.x. Use
  *   \Drupal\migrate_drupal\Plugin\MigrateFieldPluginManagerInterface instead.

Use should come in below line. It would be better if we could resolve this nitpick in this issue itself.

jofitz’s picture

@Dinesh18 Your change is correct (well spotted, good work), but is not relevant to this issue. This issue is only concerning adding the link to the change record. However valid your correction, it is out of the scope, as @Mile23 said in #6 hence why I suggested creating a new issue for it.

Dinesh18’s picture

Status: Needs review » Reviewed & tested by the community

I have created a new issue for #5 changes : https://www.drupal.org/node/2891839
Thanks @jo-fitzgerald.
#4 looks good to me . Changing the status to RTBC

  • Gábor Hojtsy committed 4adf39f on 8.3.x
    Issue #2873782 by Jo Fitzgerald, Dinesh18, vrwired: Add Change record to...

  • Gábor Hojtsy committed bb46c92 on 8.4.x
    Issue #2873782 by Jo Fitzgerald, Dinesh18, vrwired: Add Change record to...
Gábor Hojtsy’s picture

Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks, committed. Agreed that #2891839: Use word should come in next line as per deprecation policy is a won't fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children