Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add Change record to @deprecated for MigrateCckFieldPluginManagerInterface.php -- line 12
Comment | File | Size | Author |
---|---|---|---|
#4 | 2873782-4.patch | 705 bytes | jofitz |
#4 | interdiff-1-4.txt | 1002 bytes | jofitz |
MigrateCckFieldPluginManagerInterface.patch | 1.4 KB | vrwired | |
Comments
Comment #2
heddnComment #3
sorabh.v6Hey @vrwired, I downloaded patch file and tried to apply it. But its throwing error. Below is the outcome -
I suggest you to pull latest changes and recreate patch file.
Thanks for your work :)
Comment #4
jofitz CreditAttribution: jofitz at ComputerMinds commentedComment #5
Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented#4 Patch doesn't seems to follow depreciation policy.
Here is an updated patch.
Comment #6
Mile23Out of scope changes in #5. We only want to add @see for change records in this issue.
Comment #7
jofitz CreditAttribution: jofitz at ComputerMinds commentedWe can simply return to the patch in #4 so setting back to Needs Review.
@Dinesh18 It may be worth checking whether there is already an issue addressing the change you wish to make (in #5), if not create a new issue and attach your patch to that.
Comment #8
Dinesh18 CreditAttribution: Dinesh18 as a volunteer commentedIn #5, I resolved a nitpick present in #4...
Use should come in below line. It would be better if we could resolve this nitpick in this issue itself.
Comment #9
jofitz CreditAttribution: jofitz at ComputerMinds commented@Dinesh18 Your change is correct (well spotted, good work), but is not relevant to this issue. This issue is only concerning adding the link to the change record. However valid your correction, it is out of the scope, as @Mile23 said in #6 hence why I suggested creating a new issue for it.
Comment #10
Dinesh18 CreditAttribution: Dinesh18 as a volunteer commentedI have created a new issue for #5 changes : https://www.drupal.org/node/2891839
Thanks @jo-fitzgerald.
#4 looks good to me . Changing the status to RTBC
Comment #13
Gábor HojtsyThanks, committed. Agreed that #2891839: Use word should come in next line as per deprecation policy is a won't fix.
Comment #15
kay_v CreditAttribution: kay_v as a volunteer commentedRemoving parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children