Child issue of #2873705: Add change records to all @deprecated code.

Add Change record to @deprecated for MigrateIdMapInterface.php line 214

CommentFileSizeAuthor
#6 2873721-6.patch620 bytesvparfaniuc
#3 2873721-3.patch621 bytesvparfaniuc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vparfaniuc created an issue. See original summary.

vparfaniuc’s picture

vparfaniuc CreditAttribution: vparfaniuc commented
Issue tags: +Baltimore2017
vparfaniuc’s picture

vparfaniuc CreditAttribution: vparfaniuc commented
FileSize
2873721-3.patch621 bytes
edwdeapri’s picture

edwdeapri CreditAttribution: edwdeapri as a volunteer and commented

Checked/Approved file. No more @deprecated instances within file.

edwdeapri’s picture

edwdeapri CreditAttribution: edwdeapri as a volunteer and commented

Actually, the @see link needs to point to original change record.

vparfaniuc’s picture

vparfaniuc CreditAttribution: vparfaniuc commented
FileSize
2873721-6.patch620 bytes
edwdeapri’s picture

edwdeapri CreditAttribution: edwdeapri as a volunteer and at Maricopa Community Colleges commented

Successfully applied patch. Reviewed changes to code. Links to correct change record.

edwdeapri’s picture

edwdeapri CreditAttribution: edwdeapri as a volunteer and at Maricopa Community Colleges commented
Status: Active » Reviewed & tested by the community
NoahWolfe’s picture

NoahWolfe CreditAttribution: NoahWolfe as a volunteer commented

Applied successfully. +1 rbtc

vparfaniuc’s picture

vparfaniuc CreditAttribution: vparfaniuc commented
Title: Add Change record to @deprecated for MigrateIdMapInterface.php » Add Change record to @deprecated for MigrateIdMapInterface
DrupalMattS’s picture

DrupalMattS CreditAttribution: DrupalMattS commented

Checked the change request at https://www.drupal.org/node/2725809

All the deprecation links for [#2725809] have been confirmed. Checked 2724941-12.patch in the change request and found 1 instance of @deprecated which i checked against the applied patch.

Tested apply:

Confirmed successful patch applied.

  • catch committed 90c18a1 on 8.4.x 
    Issue #2873721 by vparfaniuc, edwdeapri, NoahWolfe, DrupalMattS: Add...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes
Parent issue: #2873705: Add change records to all @deprecated code »

Removing the issue relationship from fixed issues to keep the parent issue usable. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

(As a reminder, we do not need people to confirm the patch applies, because the automated testing infrastructure does that. But checking the change record is the correct one and looking for related issues and deprecations is a good way to peer-review these.)