If I select 'None' from the colorbox settings page style selectbox, the colorbox.js is never attached. I believe this to be in err, as the description for the select states, in part:
Select "None" if you have added Colorbox styles to your theme.
However, the expected behavior is that, while specific style related js and css files are not loaded, basic functionality should be present.
I tracked the issue down to the colorbox/init being only loaded as a dependency for the preset styles and not for 'None'. I see two possible fixes: either remove the check for the style being 'none' and add a library definition for 'none' or add an else where you attach colorbox/init. I'll add a patch doing the latter shortly.
Comment | File | Size | Author |
---|---|---|---|
#3 | ColorBox.png | 82.28 KB | renatog |
#2 | colorbox-none-style-init-2873669-2.patch | 433 bytes | arskiainen |
Comments
Comment #2
arskiainen CreditAttribution: arskiainen at Mirum Agency commentedHere is the patch.
Comment #3
renatogGood catch @arskiainen
I applied the patch and works good for me.
Regards
Comment #5
renatogFixed.
Commited in dev branch.
Thank you very much @arskiainen.
Good Work and Good Weekend.
Regards.