Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase).
Scope:
- All tests are in scope
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff-2872059-12-14.txt | 1.87 KB | naveenvalecha |
#14 | 2872059-14.patch | 19.47 KB | naveenvalecha |
Comments
Comment #2
mpdonadioJust the results of the browsertest-convert.php script to see what the starting point is. Some of these pass as-is, but lots of fails to dig into.
Comment #4
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #5
mpdonadioDug into this a bit. I think nearly all of the fails are because the local .po files in the tests are not being picked up, and I am not sure why. Been debugging this for a bit and am stumped :/
Comment #6
naveenvalechaHere we go.LocaleConfigTranslationImportTest:: testLocaleRemovalAndConfigOverridePreserve failed when running whole testsuite on local but passed while running explicitly.Let's see at testbot
//Naveen
Comment #8
naveenvalechaHere we go with fixes.
//Naveen
Comment #10
naveenvalechaHere we go with more fixes.
//Naveen
Comment #11
LendudeAll the (string) casts can be removed, getAttribute returns a string.
The rest looks really nice and clean.
Comment #12
naveenvalechaAddressed #11
Also removed the string casts from a couple of other places.
//Naveen
Comment #13
dawehnerI think the actual method name is getContent, but PHP doesn't care
I am wondering whether we should use assertContains here instead.
Comment #14
naveenvalecha#13.1
good catch
#13.2
Done
//Naveen
Comment #15
dawehnerThank you!
Comment #18
Gábor HojtsyLooks great, thanks all!