Problem/Motivation

Drupal\Tests\views_ui\FunctionalJavascript\ViewsListingTest was designed to check the filtering functionality in admin/structure/views. The problem is that all the numbers on that test are hardcoded and adding new views to drupal core (#1823450: [Meta] Convert core listings to Views) always require to adjust (and understand what needs to be modified) in that test.

Proposed resolution

Move the numbers to variables and do some simple calculations to replace the hardcoded numbers.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2871400-2.patch2.72 KBdagmar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dagmar created an issue. See original summary.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented
Status: Active » Needs review
FileSize
2871400-2.patch2.72 KB

Something like this.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Category: Bug report » Task
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Nice little improvement. This improves readabilty!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 581f959 to 8.4.x and bca5e6d to 8.3.x. Thanks!

Backported to 8.3.x because this is a test only change.

  • alexpott committed 581f959 on 8.4.x 
    Issue #2871400 by dagmar: Make ViewsListingTest more readable

  • alexpott committed bca5e6d on 8.3.x 
    Issue #2871400 by dagmar: Make ViewsListingTest more readable

(cherry...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.