Now that we depend on Drupal 8.3.x, we can use EntityPublishedInterface and EntityPublishedTrait.

See https://www.drupal.org/node/2830201

Comments

bojanz created an issue. See original summary.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro, Actualys commented
Status: Active » Needs review

And there is a new PR for this.

bojanz credited Berdir.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Adding Berdir, who updated the code in https://github.com/drupalcommerce/commerce/pull/763

  • bojanz committed deba412 on 8.x-2.x authored by Berdir 
    Issue #2870672 by bojanz, vasike, Berdir: Product should implement...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Rerolled, fixed test fail caused by a weird views bug (the ordering of products changed when no filter was present. Added an explicit product_id filter to account for that).

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: Product should implement EntityPublishedInterface » Berdir

filter => sort, I guess? :)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: Berdir » Product should implement EntityPublishedInterface

Wtf

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Yeah, sort :)

  • bojanz committed 477c7f2 on 8.x-2.x 
    Issue #2870672 followup: Fix the mismatched field definition error by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.