Convert web tests to browser tests for file module

I'm working on #2809503: Convert AJAX part of \Drupal\file\Tests\FileFieldWidgetTest to JavascriptTestBase, some part from there can be useful here.

Separate issue for drupalPostFormHack() #2917885: Add drupalPostFormWithInvalidOptions() to BrowserTestBase.

Patch with #2917885: Add drupalPostFormWithInvalidOptions() to BrowserTestBase and #2919352: Move methods from FileFieldTestBase to Trait.

Added mark [PP-2], but not changed status, because maybe not everything is ready.

Great points as always!

30.1: done.
30.2: follow up or fix it here - both variants ok for me.
30.3: done.
30.4: done, I really overdid it with a replacement)

opps.

Sure, done #2919872: Move part of DownloadTest::testFileCreateUrl() to a new Kernel test.

@dawehner, thank you so much too!

Current patch contains two additional chunks from next issues:

1. #2919352: Move methods from FileFieldTestBase to Trait
2. #2917885: Add drupalPostFormWithInvalidOptions() to BrowserTestBase

I'm going to close first chunk as duplicate, because it's just a transfer of methods from the Class to the Trait. It's much better to do it right here to get a good test coverage.

But the second chunk is a trait with a new method, which most likely will need to be added separately. Therefore, I will add an additional test coverage there. And while to postpone this issue like [PP-1]. Correctly?

I took the Drupal\file\Tests\FileFieldDisplayTest::testNodeDisplay() to extend the test coverage of drupalPostFormWithInvalidOptions(), and came across an interesting thing.

// Uncheck the display checkboxes and go to the preview.
$edit[$field_name . '[0][display]'] = FALSE;
$edit[$field_name . '[1][display]'] = FALSE;
$this->drupalPostForm("node/$nid/edit", $edit, t('Preview'));
$this->clickLink(t('Back to content editing'));
$this->assertRaw($field_name . '[0][display]', 'First file appears as expected.');
$this->assertRaw($field_name . '[1][display]', 'Second file appears as expected.');

Why we cann't use BTB::drupalPostForm() here?
Because $field_name . '[1][display]' not found.

But why?
Because we add new file in 'Preview' request directly.

Okay. But then we go back and check both:

$this->clickLink(t('Back to content editing'));
$this->assertRaw($field_name . '[0][display]', 'First file appears as expected.');
$this->assertRaw($field_name . '[1][display]', 'Second file appears as expected.');

What do we want to get with these asserts?
By message, that both files 'appears as expected'.

But only the first file does exist. No second file.
$this->assertRaw($field_name . '[1][display]', 'Second file appears as expected.');
This assert is passed only because the upload form already has a hidden display field with that name. It's enough to check exist of $field_name. '[1] [description]' or directly the second file itself, for confirm it.

And what suggestions?
For check the work without saving form, we can to do 'Upload' request, and only then to do 'Preview' request. Like last part of testAddValuesForFieldWithExistValues() in #2917885-24: Add drupalPostFormWithInvalidOptions() to BrowserTestBase.

Here's what I proposed to do in #38. Now the test works correctly with drupalPostForm() too.

Reroll after #1472946: Remove usages of deprecated function drupal_realpath() throughout core functions and #2919872: Move part of DownloadTest::testFileCreateUrl() to a new Kernel test.

Updated with latest version DrupalPostFormWithInvalidOptionsTrait from #2917885: Add drupalPostFormWithInvalidOptions() to BrowserTestBase.

The changes are not very readable, so here's a quick review:

1. Do not move methods form FileFieldTestBase to Trait (we can do it in #2809503: Convert AJAX part of \Drupal\file\Tests\FileFieldWidgetTest to JavascriptTestBase or reopen #2919352: Move methods from FileFieldTestBase to Trait after fix current issue).
2. Bit update phpdoc and variable name in uploadNodeFiles
   

   +   * @param bool $is_invalid
   +   *   FALSE (by default) using drupalPostForm()
   +   *   TRUE using drupalPostFormWithInvalidOptions().
   ...
   -   public function uploadNodeFiles(array $files, $field_name, $nid_or_type, $new_revision = TRUE, array $extras = [], $is_hack = FALSE) 
   +  public function uploadNodeFiles(array $files, $field_name, $nid_or_type, $new_revision = TRUE, array $extras = [], $is_invalid = FALSE) {
   

#44 it is nice idea! Thank you, @dawehner!

After epic #2346893: Duplicate AJAX wrapper around a file field we have one js-test FileFieldValidateTest::testAJAXValidationMessage().

How to do better?

1. Leave the FileFieldValidateTest only with this one test, and include it in the scope of #2809503: Convert AJAX part of \Drupal\file\Tests\FileFieldWidgetTest to JavascriptTestBase
2. Leave the full FileFieldValidateTest, and move it to separate issue or #2809503: Convert AJAX part of \Drupal\file\Tests\FileFieldWidgetTest to JavascriptTestBase.
3. Convert FileFieldValidateTest::testAJAXValidationMessage() to JTB test here.

#47: FileFieldValidateTest::testAJAXValidationMessage() leave in WTB.

class FilePrivateTest extends FileFieldTestBase
class SaveUploadFormTest extends FileManagedTestBase

Both of them need in drupalPostFormWithInvalidOptions(). Other issues can be also need this API (example, #2949091: Multiple file field with all file extensions does not work).

Opps, one unrelated change. (Edit: please ignore, incorrect branch compare Also strange, that the test run time increased by 5 minutes o_O. BTB::drupalPostForm() much slower than WTB::drupalPostForm()?)

Meh, decople FileFieldValidateTest looks ugly here, file to #2950187: Convert AJAX part of \Drupal\file\Tests\FileFieldValidateTest::testAJAXValidationMessage to JavascriptTestBase by analogy with other cases in IS.

Nit clean up.

Now the conversion is almost straight. But a couple of places:

1. +++ b/core/modules/file/tests/src/Functional/FileFieldDisplayTest.php
   @@ -97,15 +97,17 @@ public function testNodeDisplay() {
   -    $edit[$name] = \Drupal::service('file_system')->realpath($test_file->getFileUri());
   +    $edit_upload[$name] = \Drupal::service('file_system')->realpath($test_file->getFileUri());
   +    $this->drupalPostForm("node/$nid/edit", $edit_upload, t('Upload'));
   ...
   -    $this->drupalPostForm("node/$nid/edit", $edit, t('Preview'));
   +    $this->drupalPostForm(NULL, $edit, t('Preview'));
   ...
   +    $this->assertSession()->responseContains($field_name . '[1][description]', 'Description of second file appears as expected.');
   

   See #38.

2. +++ b/core/tests/Drupal/Tests/BrowserTestBase.php
   @@ -1361,4 +1361,42 @@ protected function checkForMetaRefresh() {
   +  protected function drupalPostFormWithInvalidOptions($path, $edit, $submit) {
   

   Perhaps it's too arrogant to add this helper method right here, but who will tell me the best place?

Reroll after #2864035: Convert web tests to browser tests for rdf module.

Now without extra fixes in FileFieldTestBase, without new Trait, without new method in BrowserTestBase.

Took the FileFieldValidateTest from #2950187: Convert AJAX part of \Drupal\file\Tests\FileFieldValidateTest::testAJAXValidationMessage to JavascriptTestBase, because it is trivial convertion.

Created CR + updated @trigger_error message.

Converted *Update* test (trivial changes in path to fixtures).

From CR (or trigger_error):

\Drupal\file\Tests\FileFieldTestBase have been deprecated. Instead, use \Drupal\Tests\file\Functional\FileFieldTestBase

But we definitely need to convert the api-methods from the FileFieldTestBase class to the trait. Example for create JTB tests like #2809503: Convert AJAX part of \Drupal\file\Tests\FileFieldWidgetTest to JavascriptTestBase.

It may be better to move this class to trait right now, for avoid one more record like:

\Drupal\Tests\file\Functional\FileFieldTestBase have been deprecated. Instead, use trait \Drupal\Tests\file\Traits\FileFieldTestBaseTrait

?

#54: opps, I am lol. Move methods from class to trait does not mean, that class will be deprecated :)
So, we can make trait late.