Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)
Convert
All tests except #2888905: ConvertConfigTranslationUiTest WTB to JTB & BTB for config_translation module
ConfigTranslationInstallTest
ConfigTranslationUiTest: This should be split into javascript test and BTB
Comment | File | Size | Author |
---|---|---|---|
#19 | 2870440-19.patch | 4.97 KB | naveenvalecha |
#19 | interdiff-2870440-17-19.txt | 1.36 KB | naveenvalecha |
Comments
Comment #2
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #3
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #4
dawehner@michielnugter
Just as a general typ, it would be great to explain why things are postponed. This one here for example isn't obvious for me :)
Comment #5
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedI postponed it on a test that required a base class from the system module. I updated the IS to exclude that test from the conversion and unpostponed the issue.
Comment #6
snetcher CreditAttribution: snetcher as a volunteer commentedComment #8
andypostFew fixes
Comment #9
dawehnerYou could use
assertCount
hereComment #11
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #12
naveenvalechaRewrote the whole conversion as the above patch was not getting applied.
//Naveen
Comment #14
naveenvalechaDo we have any existing follow-up issue where are we adding the helper function drupalPostWithFormat?
//Naveen
Comment #15
naveenvalecha#14 This patch removed the conversion of the ConfigTranslationUiTest. Updated the issue summary accordingly.
//Naveen
Comment #17
naveenvalechaHere we go with fixes
//Naveen
Comment #18
dawehnerWhat about using $dropbutton->find('li') instead of testing the HTML directly?
Comment #19
naveenvalechayup we could use that. Accommodated #18
//Naveen
Comment #20
dawehnerI like it, thank you @naveenvalecha!
Comment #23
Gábor HojtsyThanks all, agreed it looks good.