Problem/Motivation

The priority in document for Drupal\Core\DependencyInjection\Compiler\StackedKernelPass confused me:

/**
 * Provides a compiler pass for stacked HTTP kernels.
 *
 * Builds the HTTP kernel by collecting all services tagged 'http_middleware'
 * and assembling them into a StackedKernel. The middleware with the lowest
 * priority ends up as the outermost while the highest priority middleware
 * wraps the actual HTTP kernel defined by the http_kernel.basic service.

Proposed resolution

The highest middleware should be outermost while the lowest wraps the http_kernel.basic service;

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edwardaa created an issue. See original summary.

edaa’s picture

edaa’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2869741-1.patch, failed testing.

edaa’s picture

edaa’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: 2869741-5.patch, failed testing.

edaa’s picture

Status: Needs work » Needs review
FileSize
1.14 KB

fix file path

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

You are absolutely right. Nice catch!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 479813c to 8.4.x and 83efd31 to 8.3.x. Thanks!

Backported to 8.3.x because this is a documentation fix.

  • alexpott committed 479813c on 8.4.x
    Issue #2869741 by edwardaa: FIx http_middleware priority explanation
    

  • alexpott committed 83efd31 on 8.3.x
    Issue #2869741 by edwardaa: FIx http_middleware priority explanation
    
    (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.