Problem/Motivation

The LayoutPluginManager should use ContainerDerivativeDiscoveryDecorator so that layout plugins can have a deriver that implements ContainerDeriverInterface.

Proposed resolution

Use ContainerDerivativeDiscoveryDecorator instead of DerivativeDiscoveryDecorator

Remaining tasks

review patch.

User interface changes

none

API changes

extension: allows derivers to use services.

Data model changes

none

CommentFileSizeAuthor
#2 2868949-2.patch1.62 KBbircher
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bircher created an issue. See original summary.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher at Nuvole commented
Status: Active » Needs review
FileSize
2868949-2.patch1.62 KB
ademarco’s picture

ademarco CreditAttribution: ademarco at Nuvole commented
Status: Needs review » Reviewed & tested by the community

Works well, marking as RTBC.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher at Nuvole commented
Component: plugin system » layout.module
Issue tags: +Contributed project blocker

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2868949-2.patch, failed testing.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher at Nuvole commented
Status: Needs work » Reviewed & tested by the community

Drupal CI, you are drunk..

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Category: Bug report » Task
Priority: Major » Normal
Issue tags: -Contributed project blocker +Contributed project soft blocker

This is neither major nor a bug, but it is a solid improvement.
Thanks, and +1 for RTBC

  • cilefen committed d9b4e68 on 8.4.x 
    Issue #2868949 by bircher: LayoutPluginManager should use...
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Reviewed & tested by the community » Fixed

Committed d9b4e68 and pushed to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Chi’s picture

Chi CreditAttribution: Chi commented
Related issues: +#2904189: WSOD Drupal

Is it possible to commit this fix to 8.3.x as well? Using deriver that implements ContainerDeriverInterface leads to fatal error on Drupal 8.3.