API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Database%...

public function ConditionInterface::conditionGroupFactory describes the first parameter, when "OR" is specified, as equivalent to the "andConditionGroup()" method. This should read "orConditionGroup()".

CommentFileSizeAuthor
#2 2868759-2.patch682 bytesdpagini
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpagini created an issue. See original summary.

dpagini’s picture

dpagini CreditAttribution: dpagini as a volunteer commented
FileSize
2868759-2.patch682 bytes

Attempting my first patch for core... documentation seems like a good place to start. Please be gentle. =)

dpagini’s picture

dpagini CreditAttribution: dpagini as a volunteer commented
Title: ConditionInterface::conditionGroupFactory API documentation typo » ConditionInterface::conditionGroupFactory API documentation typo AND/OR
Assigned: dpagini » Unassigned
Status: Active » Needs review
dpagini’s picture

dpagini CreditAttribution: dpagini as a volunteer commented
Version: 8.3.x-dev » 8.4.x-dev

I suppose this is a bump, going to put this against 8.4.x-dev instead of 8.3.x-dev and see if that changes anything. I'm not sure I'm confident which one is more correct in this case...?

dpagini’s picture

dpagini CreditAttribution: dpagini as a volunteer commented
Version: 8.4.x-dev » 8.3.x-dev

Changing to 8.3.x-dev per Drupalcon Mentored Core Sprint feedback.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

  • Gábor Hojtsy committed 56f85f2 on 8.3.x 
    Issue #2868759 by dpagini: ConditionInterface::conditionGroupFactory API...

  • Gábor Hojtsy committed 23ec4d5 on 8.4.x 
    Issue #2868759 by dpagini: ConditionInterface::conditionGroupFactory API...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Good find, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.