Refactor \Drupal\Tests\rest\Functional\EntityResource\Block\BlockResourceTestBase::getExpectedCacheTags

I'm concerned about the scope of changes here. Let's focus on only the one truly relevant change.

1. +++ b/core/modules/rest/tests/src/Functional/EntityResource/Block/BlockResourceTestBase.php
   @@ -5,6 +5,9 @@
   +/**
   + * ResourceTestBase for Block entity.
   + */
   

   This is just such a pointless docblock. We don't have it on any of the other base test classes. Let's not add it here either.

2. +++ b/core/modules/rest/tests/src/Functional/EntityResource/Block/BlockResourceTestBase.php
   @@ -18,6 +21,8 @@
   +   * The Block entity.
   

   Same for this. Needless verbosity.

3. +++ b/core/modules/rest/tests/src/Functional/EntityResource/Block/BlockResourceTestBase.php
   @@ -30,9 +35,11 @@ protected function setUpAuthorization($method) {
   +
   ...
   +
   
   @@ -138,6 +143,7 @@ protected function getExpectedUnauthorizedAccessMessage($method) {
   +
   

   And these are just whitespace changes. The same absence of whitespace exists in the other base classes.

4. +++ b/core/modules/rest/tests/src/Functional/EntityResource/Block/BlockResourceTestBase.php
   @@ -122,9 +129,7 @@ protected function getExpectedCacheContexts() {
   -    return array_values(array_filter(parent::getExpectedCacheTags(), function ($tag) {
   -      return $tag !== 'config:user.role.anonymous';
   -    }));
   +    return array_values(array_diff(parent::getExpectedCacheTags(), ['config:user.role.anonymous']));
   

   This is a solid change however! :)

Thanks :)

According to above comment, Only added the refactor patch. :)

Oops Sorry. It was a coincidence. Apologise.

Retested both #4 and #7. They're both failing, because Drupal CI is crashing, hard.

Committed/pushed to 8.4.x, thanks!