Convert web tests to browser tests for contextual module

To be honest I would prefer to use the HTTP client directly here, its clear what goes on then.

Setting it back to needs work.

The test can be fixed with one of these options:
- calling drupalPostForm with the proper requirements
- Converting to JavascriptTestBase if it is actually testing Javascript behavior
- Use the HTTP client directly.

I'm going to work on this one to try and address the failing tests.

Following the direction in #3 and #4, I have used HTTP client.

Check out HistoryTest::getHttpClient().

There are a few other examples of doing this kind of thing, which is why I filed #2911915: Add getHttpClient() to BrowserTestBase to address converting tests that need http requests.

I introduced some whitespace into my last patch. Resupplying.

Apologises. Ignore patches in #11. Wrong issue.

Let's postpone on the issue linked by @mile23 #2911915: Add getHttpClient() to BrowserTestBase

We need to postpone on #2911915: Add getHttpClient() to BrowserTestBase

This is now unblocked since #2911915: Add getHttpClient() to BrowserTestBase was fixed.

Here it is.

Once more, let's check if it's the reason.

Nice and clean conversion, thank you.

+++ b/core/modules/contextual/tests/src/Functional/ContextualDynamicContextTest.php
@@ -174,15 +174,23 @@ protected function assertNoContextualLinkPlaceHolder($id) {
+    $http_client = $this->getHttpClient();
...
+      'cookies' => $this->getSessionCookies(),

it was worth waiting for these additions, looks really clean like this.

This was the only remaining webtest test in the contextual module, so the scope is correct being just one test. Updated the IS to reflect this.

Committed and pushed 72d0bff47d to 8.7.x and abec12fbab to 8.6.x. Thanks!