Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
\Drupal\Core\Menu\MenuLinkTree
does not document its $menuLinkManager
variable.
Proposed resolution
Document it! (Just like all the other variables in the there...)
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#9 | after-apply-patch.png | 60.59 KB | amit.drupal |
#9 | before-apply-patch.png | 69.15 KB | amit.drupal |
#3 | menulinkmanager-2865295-3.patch | 597 bytes | JayKandari |
Comments
Comment #2
JayKandariComment #3
JayKandariChanges applied. Kindly review!
Comment #4
tstoecklerPerfect, thank you!
Comment #5
lauriiiComment #6
lauriiiSorry, I misread the patch :)
Comment #7
amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedPatch Is beautifully work.
Comment #8
renatogHi guys.
I applied the patch, study and looks good for me.
Thank you very much @jaykandari.
Good Work.
Regards.
Comment #9
amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedAfter Review Patch Submit Screenshot.
Comment #10
Gábor HojtsyComment #13
Gábor HojtsyLooks good, the property was already in use but was indeed undocumented. Thanks all!
Comment #14
penyaskitoThis change introduced a probably undesired API change. Lauri was right in #5, this change changed visibility from public to protected.
I'm quite sure we don't want to revert this, but worth to notice that we may want a change record?
Comment #15
Gábor HojtsyAre undocumented object properties (which are consequentially public) part of the API as we define it? That sounds accidental :)
Comment #16
penyaskitoGood call, thanks :-)
Comment #17
penyaskitoGood call, thanks :-)