Advanced help module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#6 find_array.png8.41 KBdhruveshdtripathi
#4 short_array_syntax-2864651-4.patch4.07 KBamit.drupal
#4 find-array.png6.64 KBamit.drupal
#2 short_array_syntax-2864651-2.patch1.07 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2864651-2.patch1.07 KB
gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer commented
Status: Needs review » Needs work

Thanks for your patch!

But accord with this command you are still are missing few arrays:

grep -rn "array("  .   | wc -l
      17

In your patch you only replace 2 arrays and are 17.

This might help:

https://github.com/Lendude/php-short-array-syntax-converter

Thanks!

amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
find-array.png6.64 KB
short_array_syntax-2864651-4.patch4.07 KB

@gnuget

Thanks For suggestion for use : https://github.com/Lendude/php-short-array-syntax-converter

amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
FileSize
find_array.png8.41 KB

Patch applied cleanly. Only one array( left that is from html file. Good work.

  • gnuget committed ed80f44 on 8.x-1.x authored by amit.drupal 
    Issue #2864651 by amit.drupal, Munavijayalakshmi, dhruveshdtripathi:...
gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.