Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Split off from #2747167: Convert first part of web tests of views_ui.
The test has problems with updating radio buttons, the changes don't seem to have effect.
Comment | File | Size | Author |
---|---|---|---|
#13 | 2864610-13.patch | 4.56 KB | Manuel Garcia |
#13 | interdiff.txt | 2.82 KB | Manuel Garcia |
#9 | 2864610-4_1381140-129_combined.patch | 11.04 KB | Manuel Garcia |
#7 | Screenshot from 2017-08-04 10-54-40.png | 4.78 KB | Manuel Garcia |
#3 | 2864610-3.patch | 982 bytes | andypost |
Comments
Comment #2
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #3
andypostinitial patch, does not pass locally
Comment #4
andypostfixed few assertions, somehow result value is different
Comment #7
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commentedI've had a look at the failing test, but could not figure out why it fails. Here some of my findings / thoughts:
\Drupal\FunctionalTests\AssertLegacyTrait::assertFieldChecked()
works differently than\Drupal\simpletest\AssertContentTrait::assertFieldChecked()
so that might be why these fail, or it might be a legitimate failure?I had a look at the html produced by the test, and
checked="checked"
is pressent on the right elements, although when its rendered it looks like this:Comment #8
Lendude@Manuel Garcia Ha, you ran into my favourite Drupal bug! #1381140: A #default_value = 0 for #type radios checks all radios
Comment #9
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commentedOw wow, so it is a legitimate bug - thanks @Lendude for the info!
I went ahead and tested #4 patch with #1381140: A #default_value = 0 for #type radios checks all radios (#129) applied, and it passes, so that's great news. Uploading the combined patch here just to make sure.
Comment #10
Lendude#9 is pretty clear, lets postpone on #1381140: A #default_value = 0 for #type radios checks all radios
Comment #11
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commented#1381140: A #default_value = 0 for #type radios checks all radios landed yay!
Comment #12
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commentedRe-testing #4...
Comment #13
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commentedThis should hopefully come back green =)
Comment #14
LendudeNice.
The remaining tests in Views UI have separate issues, so the scope here is correct.
Comment #17
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!