Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#13 | convert_web_tests_to-2863996-13.patch | 8.56 KB | nlisgo |
#13 | interdiff-12-13.txt | 1.41 KB | nlisgo |
#12 | 2863996-12.patch | 8.57 KB | jofitz |
#12 | interdiff-10-12.txt | 1.41 KB | jofitz |
#10 | convert_web_tests_to-2863996-10.patch | 8.59 KB | nlisgo |
Comments
Comment #2
nlisgo CreditAttribution: nlisgo commentedComment #3
nlisgo CreditAttribution: nlisgo commentedComment #4
scuba_flyRan the test locally. Don't see any simpletest / WebTestBase on the new code so that's good.
Attached is a green OK result of running the test in my phpstorm.
+1
Comment #5
dawehnerYou can use
assertSame
instead hereComment #6
dawehnerComment #7
nlisgo CreditAttribution: nlisgo commentedAddressed the feedback in #5.
Thanks @dawehner
Comment #9
nlisgo CreditAttribution: nlisgo commentedNew patch incoming. Not sure why composer.lock changes were in my patch.
Comment #10
nlisgo CreditAttribution: nlisgo commentedI created the diff in #7 from my local 8.4.x which was one commit behind HEAD and I had rebased my feature branches to origin/8.4.x! doh!
This patch should take!
Comment #11
dawehnerNote: you can use
assertCount
here.Comment #12
jofitz CreditAttribution: jofitz at ComputerMinds commentedChanged
assertSame()
toassertCount()
.Comment #13
nlisgo CreditAttribution: nlisgo commentedChanged assertSame() to assertCount() in CKEditorAdminTest::testNewFormat()
Comment #14
dawehnerThank you both!
Comment #15
Wim LeersAs a maintainer of the CKEditor module, I think this looks great :) Thanks!
Comment #16
alexpottCommitted and pushed 40d1faf to 8.4.x and 36657a4 to 8.3.x. Thanks!
As a test-only change backported to 8.3.x