Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)
Convert:
- Only ResponsiveImageAdminUITest
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2863984-13.patch | 2.16 KB | jofitz |
| #13 | interdiff-2-13.txt | 3.04 KB | jofitz |
| #2 | convert_web_tests_to-2863984-2.patch | 7.03 KB | GoZ |
Comments
Comment #2
GoZ CreditAttribution: GoZ at Barbe-Rousse, Centarro commentedComment #3
dawehnerIt feels like we should maybe have some JS test coverage for these forms, just wondering ...
Comment #4
dawehnerDo you mind actually converting it to a JS test?
Comment #5
dawehnerI guess its the same kind of case as #2780063: Convert web tests to browser tests for datetime and datetime_range modules
Comment #6
GoZ CreditAttribution: GoZ at Barbe-Rousse, Centarro commented@dawehner are you sure about duplicate with #2780063: Convert web tests to browser tests for datetime and datetime_range modules ?
this seems to have nothing to do with datetime module.
Comment #7
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedI don't think it's a duplicate either. There are some tests that should be Browser tests. I have postponed this one on the JavascriptTestBase conversion though: #2809513: Convert AJAX part of \Drupal\responsive_image\Tests\ResponsiveImageFieldUiTest to JavascriptTestBase and the rest to BrowserTestBase. We need to get that in first and then finish up this issue.
Comment #8
dawehnerI have no idea what I was thinking :P
Comment #9
GoZ CreditAttribution: GoZ at Barbe-Rousse, Centarro commented@dawehner there is some days like that.
As other postponed WTB to BTB issues, may be we could create an issue for the postponed JavascriptTestBase and at least convert what can be converted right now ?
Comment #10
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedI looked again at the module and there are 3 tests in the module:
- 1 can be converted directly without dependencies (ResponsiveImageAdminUITest)
- 1 has at least a partial conversion to JTB (ResponsiveImageFieldUiTest)
- 1 has a dependency on image (ResponsiveImageFieldDisplayTest).
I changed the scope for this issue to only the AdminUITest, increased the scope for the JavascriptTestBase conversion and moved ResponsiveImageFieldUiTest out of this scope and into the follow-up for image (yet to be created).
Can you reroll the patch with only the ResponsiveImageAdminUITest test?
Comment #11
dawehnerI'm wondering whether we should make it clear in the title how much of the tests are gonna be converted?
Comment #12
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #13
jofitz CreditAttribution: jofitz at ComputerMinds commentedRerolled the patch with only the ResponsiveImageAdminUITest test, as requested in #10.
Comment #14
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedThanks, looks good to me!
Comment #15
dawehnerNice. One step towards it!
Comment #17
catchCommitted/pushed to 8.4.x, thanks!