Currently when you enable Editing mode, leave editing mode and then enable it again.
The announcement message is wrong.
ChromeVox reads:
Tabbing is no longer constrained by the Contextual module.
Tabbing is constrained to a set of 11 contextual links and the edit mode toggle.
Press the esc key to exit.
This should just be:
Tabbing is constrained to a set of 11 contextual links and the edit mode toggle.
Press the esc key to exit.
Comment | File | Size | Author |
---|---|---|---|
#15 | 2863222-15.patch | 4.85 KB | tedbow |
#15 | interdiff-2863222-11-15.txt | 1.95 KB | tedbow |
#11 | interdiff-2863222-10-11.txt | 1.85 KB | GrandmaGlassesRopeMan |
#11 | 2863222-11.patch | 4.86 KB | GrandmaGlassesRopeMan |
#10 | 2863222-10.patch | 4.2 KB | dmsmidt |
Comments
Comment #2
dmsmidtHere is a patch that fixes the problem.
Comment #3
GrandmaGlassesRopeManI think this should be testable.
Comment #4
tedbowThis actually happens with the Contextual module without the Settings Tray module enabled. So switching component. I will work on a test for this.
Comment #5
tedbowOk I added a test to the patch. I also added a TEST_ONLY patch.
The TEST_ONLY patch should fail as
So line 61 is when edit mode has been enabled and disabled then re-enabled.
This should prove the problem and the fix.
Comment #7
tedbowForgot to upload TEST_ONLY first, regular patch passed.
Comment #8
dmsmidtTest looks good and works as advertised.
This benefits from some extra documentation. Patch attached.
Edit: booo, something went wrong here. New patch comming up. (Note to self: Check first, upload later)
Comment #10
dmsmidtComment #11
GrandmaGlassesRopeMan- reroll due to es6 implementation.
Comment #12
tedbow#10 and #11 look to me.
I think ready to RTBC but I wrote the tests.
Comment #13
tim.plunkettNo need for a constant just for one usage. Also this could be a one-liner
Idk where this habit started, but I personally think it's overkill. Also afaik it would need a docblock.
No need for the $user variable, can just wrap createUser in drupalLogin
Tests, Presses, Asserts
Comment #14
dmsmidtAs per Tims comments needs work.
However, 1):
ANNOUNCE_SELECTOR
is used four times. I guess 1) and 2) are aboutEDIT_BUTTON_SELECTOR
. Then I agree.Comment #15
tedbow@tim.plunkett thanks for the review 😀
re #13
1. removed EDIT_BUTTON_SELECTOR because it was only used once. Left ANNOUNCE_SELECTOR because it is used for times.
2. Added a doc block for ANNOUNCE_SELECTOR. I like using them for strings used more that once
3. ✔ fixed
4. ✔ fixed
Comment #16
tim.plunkettGot my dreditor highlights off a bit, glad you understood what I meant.
Comment #17
GrandmaGlassesRopeMan🎉
Comment #19
catchCommitted/pushed to 8.4.x, thanks!
This doesn't cherry-pick cleanly to 8.3.x, I think it's OK for it to be in 8.4.x and not backported.