Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add API documentation.
See the documentation in the process plugins for format examples.
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff-2862746-4-8.txt | 772 bytes | masipila |
#8 | 2862746-8.patch | 1.99 KB | masipila |
#4 | 2862746-4.patch | 1.98 KB | masipila |
Comments
Comment #3
masipila CreditAttribution: masipila as a volunteer commentedComment #4
masipila CreditAttribution: masipila as a volunteer commentedPatch attached.
I'll write a FieldInstance pair for this probably tomorrow, #2862745: Add documentation to EntityFieldInstance destination plugin
Comment #5
phenaproximaLooks good. Only a couple of things:
Can we replace "FieldStorage configuration" with "field_storage_config"?
Nit: Can there be an extra blank line before @code?
Comment #6
masipila CreditAttribution: masipila as a volunteer commentedHi, thanks for a super fast review!
1. Of course we can but why would we want to? The name of the config entity this plugin is creating is FieldStorage... I can change this of course as suggested but I would like to understand the rationale...
2. Not according to the API documentation coding standards. The paragraph explaining the code must not have a linebreak between the paragraph and @code/@endcode.
Cheers,
Markus
Comment #7
masipila CreditAttribution: masipila as a volunteer commentedComment #8
masipila CreditAttribution: masipila as a volunteer commentedWe discussed #5.1 in IRC with @phenaproxima and the rationale of using field_storage_config instead of FieldStorage is that field_storage_config is the ID of the config entity type.
Comment #9
quietone CreditAttribution: quietone as a volunteer commentedThe points in #5 have been address and I have none of my own. This is good to go!
Comment #10
Gábor HojtsyComment #13
Gábor HojtsyLooks great, thanks!