Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The error thrown when the profile for an already installed site is changed in config is misleading: 'from %new_profile to %profile'. Took me a longer to figure what was going on because of this.
Comment | File | Size | Author |
---|---|---|---|
#7 | config_import_change-2862207-7.patch | 1.9 KB | kalpaitch |
Comments
Comment #2
jmmarquez CreditAttribution: jmmarquez commentedI am working on it!!
Comment #3
jmmarquez CreditAttribution: jmmarquez commentedUploading patch.
Comment #5
jmmarquez CreditAttribution: jmmarquez commentedI'm still reviewing it
Comment #6
kalpaitch CreditAttribution: kalpaitch as a volunteer and commentedGood good, just needs the same amendment to the tests.
Comment #7
kalpaitch CreditAttribution: kalpaitch as a volunteer and commentedOops, both patches together then...
Comment #8
jmmarquez CreditAttribution: jmmarquez commentedOk, so it should be fixed now?
Comment #9
kalpaitch CreditAttribution: kalpaitch as a volunteer and commentedSupposedly :)
Comment #10
jmmarquez CreditAttribution: jmmarquez at La Drupalera by Emergya for La Drupalera by Emergya commentedComment #11
jmmarquez CreditAttribution: jmmarquez at La Drupalera by Emergya for La Drupalera by Emergya commentedComment #13
kalpaitch CreditAttribution: kalpaitch as a volunteer and commentedbump
Comment #14
borisson_Instead of switching the %profile and %new_profile around, we should switch the variable around in the arguments intead.
Comment #15
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedHi borisson,
I think code is correct.
Comment #16
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedcode is working fine for me. Good Job !
Comment #17
borisson_Oh wow, I completely misread the interdiff, yeah this does look correct. Thanks for pointing that out @jeetendrakumar!
Comment #18
xjmBased on the comment, it looks like the message should also be different if the install profile name is not set. Otherwise the message is still confusing.
That is not in scope for this bugfix, though, so I filed #2929505: Fix config importer error message when a profile name is empty.
Saving issue credit.
Comment #21
xjmNormally, string changes aren't allowed changes in patch releases. However, in this situation, the string is purely wrong, so it is better to require re-translation than to keep the old string. So, tagging as a string change in the next patch release.
I think this is also a normal issue (not minor) because it is a functional bug and does affect debugging for config imports (as described in the summary).
Committed and pushed to 8.5.x, and backported to 8.4.x. Thanks!