When editing DFP tags, the description of the amp_size is

Enter the size for this tag when displayed on AMP pages. If not entered, the smallest size will be used. Example: 300x250

but if I leave it empty I get an error message saying

AMP Size is in an invalid format.

Looks like we need to change the validation to allow empty values

CommentFileSizeAuthor
#3 amp_size_validation-2861566-3.patch659 bytesmarcelovani
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcelovani created an issue. See original summary.

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani commented
Title: AMP size should not be required » AMP size validation
Issue summary: View changes
marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani commented
Status: Active » Needs review
FileSize
amp_size_validation-2861566-3.patch659 bytes

Function Isset()

Returns TRUE if var exists and has value other than NULL. FALSE otherwise.

Easy fix, please review

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Assigned: marcelovani » Unassigned
marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Priority: Normal » Major

Changed priority, this is stopping me from saving the form without a size

kalpaitch’s picture

kalpaitch CreditAttribution: kalpaitch as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Of course.

  • marcelovani committed 41a470f on 7.x-1.x 
    Issue #2861566 by marcelovani: AMP size validation
marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.