Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In Core Update 8.2.7 (Security Update SA-CORE-2017-001)
It seems the class 'search-block-form' has been removed from the main search block in core theme 'classy'.
Whilst not a bug as such, this does mean themes either based on or sub themes of classy that use this class as an obvious theming/CSS hook for styling their main search box, will find this styling breaks after an update to 8.2.7.
Is there a security reason to remove this class?
Comment | File | Size | Author |
---|---|---|---|
#4 | useful_class_removed-2861127-3.patch | 752 bytes | lauriii |
Comments
Comment #2
TheThemerist CreditAttribution: TheThemerist commentedComment #3
Berdir> Is there a security reason to remove this class?
No.
That's just me being blind/stupid, can safely be removed.
Comment #4
lauriiiThis brings the class back
Comment #5
TheThemerist CreditAttribution: TheThemerist as a volunteer commentedThanks guys!
We only have a handful of live Drupal 8 sites here, so it wasn't too much trouble just to find-replace the class name we'd used for something more robust.
But i imagined for some who have shipped out quite a few D8 sites it may cause a bigger problem.
Thanks for the Patch lauriii
Comment #6
BerdirThis looks fine to me but I guess it will only be added to 8.3 as there will be no further 8.2.x releases.
Comment #9
xjmYep, we agreed to fix this in 8.3.x, since the next release after 8.2.7 is 8.3.0.
Committed to 8.4.x and cherry-picked to 8.3.x. Thanks @themeninja for reporting this!
Comment #10
xjm