There should not be link to rate thumb down button if user has not permission to vote.

CommentFileSizeAuthor
#12 rate-2861114-12.patch10.12 KBKrzysztof Domański
#10 rate-2861114-10.patch9.8 KBKrzysztof Domański
#10 rate-2861114-test-only.patch9.22 KBKrzysztof Domański
#10 interdiff-7.10.txt12.58 KBKrzysztof Domański
#7 rate-2861114-7.patch9.64 KBKrzysztof Domański
#7 rate-2861114-test-only.patch9.06 KBKrzysztof Domański
#7 interdiff-2-7.txt9.52 KBKrzysztof Domański
#2 Their_should_not_be_link_to_rate_thumb_down_button_if_article_is_already_rated-2861114-#1.patch807 bytesganesh_paygude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ganesh_paygude created an issue. See original summary.

ganesh_paygude’s picture

ganesh_paygude
Primary language English
Location Pune
CreditAttribution: ganesh_paygude at Clarion Technologies commented
FileSize
Their_should_not_be_link_to_rate_thumb_down_button_if_article_is_already_rated-2861114-#1.patch807 bytes

Here is the patch for the same.

Thanks

ganesh_paygude’s picture

ganesh_paygude
Primary language English
Location Pune
CreditAttribution: ganesh_paygude at Clarion Technologies commented
Title: Their should not be link to rate thumb down button if article is already rated. » Their should not be link to rate thumb down button if user has not permission to vote.
Issue summary: View changes
ganesh_paygude’s picture

ganesh_paygude
Primary language English
Location Pune
CreditAttribution: ganesh_paygude commented
ganesh_paygude’s picture

ganesh_paygude
Primary language English
Location Pune
CreditAttribution: ganesh_paygude commented
Assigned: ganesh_paygude » Unassigned
Status: Active » Needs review
kevin.dutra’s picture

kevin.dutra CreditAttribution: kevin.dutra at Workday, Inc. commented
Status: Needs review » Needs work 
+++ b/templates/rate-template-thumbs-up-down.html.twig
@@ -41,8 +41,5 @@
-  {% if undo %}

The undo link must be present for the widget, so this part needs to stay.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Needs work » Needs review
FileSize
interdiff-2-7.txt9.52 KB
rate-2861114-test-only.patch9.06 KB
rate-2861114-7.patch9.64 KB

I added tests and I agree with #6.

The last submitted patch, 7: rate-2861114-test-only.patch, failed testing. View results

JordiK’s picture

JordiK CreditAttribution: JordiK commented
Title: Their should not be link to rate thumb down button if user has not permission to vote. » There should not be link to rate thumb down button if user has not permission to vote.
Issue summary: View changes
Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
FileSize
interdiff-7.10.txt12.58 KB
rate-2861114-test-only.patch9.22 KB
rate-2861114-10.patch9.8 KB

Let's make tests easier.

The last submitted patch, 10: rate-2861114-test-only.patch, failed testing. View results

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
FileSize
rate-2861114-12.patch10.12 KB

Re-roll

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.