Problem/Motivation

Currently after install of amp module, imported configuration is not same as provided configuration in yaml files and it should be.

Way to reproduce it:
1. install module on clean installation of drupal + amp
2. install config_update and config_update_ui module
3. with config_update_ui module it's possible to see differences in configuration page
-> after clean install there should not be any difference between active configuration and original configuration (from yaml files)

Proposed resolution

All what is needed is new export of configuration files, so that they are in sync with active configuration.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

Status: Active » Needs review
FileSize
1.2 KB

Here is patch with adjusted original configuration.

Status: Needs review » Needs work

The last submitted patch, 2: cleanup_default-2860803-2.patch, failed testing. View results

KarenS’s picture

Status: Needs work » Needs review
FileSize
1.63 KB

Patch needs a re-roll, and the configuration looks slightly different now.

  • KarenS committed 78bd663 on 8.x-1.x authored by chr.fritsch
    Issue #2860803 by chr.fritsch: Cleanup default configuration
    
KarenS’s picture

Status: Needs review » Fixed

Fixed. Thanks!

daniel.bosen’s picture

Status: Fixed » Needs work

The patch that has been merged does not contain the deletion of the empty file "field.formatter.settings.image.amp.yml", see original patch "cleanup_default-2860803-2.patch"

  • KarenS committed cddec19 on 8.x-2.x
    Issue #2860803 by chr.fritsch: Cleanup default configuration
    

  • KarenS committed 84490d0 on 8.x-3.x
    Issue #2860803 by chr.fritsch: Cleanup default configuration
    

  • KarenS committed a9196be on 8.x-1.x
    Issue #2860803 by chr.fritsch: Cleanup default configuration
    
KarenS’s picture

Status: Needs work » Fixed

Fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.