Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi, the next notice is appeared on the migrate source page:
Notice: Undefined index: row_index_colums in Drupal\migrate_spreadsheet\Plugin\migrate\source\Spreadsheet->fields() (line 103 of modules/contrib/migrate_spreadsheet/src/Plugin/migrate/source/Spreadsheet.php).
Looks like this check:
if (!empty($row_index_column = $this->getConfiguration()['row_index_colums'])) {
is not correct, because it doesn't check if 'row_index_colums' exists.
I have attached a patch to fix this notice for reviewing.
Comment | File | Size | Author |
---|---|---|---|
#4 | migrate_spreadsheet-2857573-misspelled-row_index_column.patch | 682 bytes | drupalmonkey |
#2 | 1871x617-Selection_03_03_2017_001.png | 142.5 KB | alan-ps |
#2 | migrate_spreadsheet-undefined_index_row_index_colums.patch | 825 bytes | alan-ps |
Comments
Comment #2
alan-ps CreditAttribution: alan-ps commentedComment #3
codesmithI think that's a different bug. The key should be 'row_index_column' -- not 'row_index_colums'.
Comment #4
drupalmonkey CreditAttribution: drupalmonkey at Digital Bridge Solutions commentedThis is the correct patch for this issue. You don't need to check if row_index_column is set here, you just need to spell it right. It will always be set from defaultConfiguration() and setConfiguration().
Comment #6
claudiu.cristeaThank you for catching this and for the patch.
Comment #8
claudiu.cristeaFixed. Thank you!