CommentFileSizeAuthor
#16 rerolled-2855434-16.patch9.27 KBVidushi Mehta
#13 interdiff-11-13.txt2.34 KBsubson
#13 token-replace_usages_of_deprecated_entity_create-2855434-13.patch9.27 KBsubson
#11 rerolled-2855434-11.patch6.95 KBVidushi Mehta
#9 patchapplied.JPG40.03 KBdeepakkumar14
#6 interdiff-2855434-4-6.txt7.59 KBMatroskeen
#6 token-replace_usages_of_deprecated_entity_create-2855434-6-D8.patch.patch7.73 KBMatroskeen
#4 interdiff.txt922 bytesdeepakkumar14
#4 token-replace_usages_of_deprecated_entity_create-2855434-3.patch7.76 KBdeepakkumar14
#2 token-replace_usages_of_deprecated_entity_create-2855434-2.patch6.95 KBbkhandruk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

bkhandruk CreditAttribution: bkhandruk commented
Assigned: bkhandruk » Unassigned
Status: Active » Needs review
FileSize
token-replace_usages_of_deprecated_entity_create-2855434-2.patch6.95 KB

Replaced all usages of entity_create.

Status: Needs review » Needs work

The last submitted patch, 2: token-replace_usages_of_deprecated_entity_create-2855434-2.patch, failed testing.

deepakkumar14’s picture

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
token-replace_usages_of_deprecated_entity_create-2855434-3.patch7.76 KB
interdiff.txt922 bytes

I have reviewed the patch in #2 it is not replacing all the entity_create function of module.
So i have created a new patch for it.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Assigned: Unassigned » Matroskeen
Issue tags: +LutskGSW18
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Assigned: Matroskeen » Unassigned
FileSize
token-replace_usages_of_deprecated_entity_create-2855434-6-D8.patch.patch7.73 KB
interdiff-2855434-4-6.txt7.59 KB

I've replaced \Drupal::entityTypeManager() with generic Entity classes.
Drupal core tests use this approach, so probably it should be done in this way.

All tests were passes locally.

Patch and interdiff are attached. Please review.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Tested the patch and it's looking good.Moving to RTBC.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Needs work

Will need a reroll.

deepakkumar14’s picture

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
patchapplied.JPG40.03 KB

I have pulled latest code and applied patch #6 and its working fine.

Status: Needs review » Needs work

The last submitted patch, 6: token-replace_usages_of_deprecated_entity_create-2855434-6-D8.patch.patch, failed testing. View results

Vidushi Mehta’s picture

Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
rerolled-2855434-11.patch6.95 KB

Here's a rerolled patch.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

Looks good for me.

subson’s picture

subson CreditAttribution: subson as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
token-replace_usages_of_deprecated_entity_create-2855434-13.patch9.27 KB
interdiff-11-13.txt2.34 KB

re-rolling the patch along with changes from this issue - #2932591: entity_create, entity_load and other similar functions are deprecated

ApacheEx’s picture

ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

The patch from #13 looks clean and done with minimal changes :)
Make it as RTBC.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Needs work

That's the problem with those deprecation/coding style patches, they conflict easily. Sorry but this needs a reroll.

Vidushi Mehta’s picture

Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
rerolled-2855434-16.patch9.27 KB

Patch rerolled.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Needs review » Reviewed & tested by the community

Looks good!

  • Berdir committed 203352b on 8.x-1.x authored by Vidushi Mehta 
    Issue #2855434 by Vidushi Mehta, deepakkumar14, Matroskeen, subson,...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Already conflicted again, fixed and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.