This module have a deprecated methods(\Drupal::url(), \Drupal::entityManager()) and functions (db_insert(), db_update(), db_query(), drupal_render_children(), entity_get_form_display())

CommentFileSizeAuthor
#14 2855165-14-D8-deprecated_methods_and_function__replaced_REQUEST_TIME.patch2.99 KBalunyov
#10 2855165-10-D8-deprecated_methods_and_function__fixed_critical_issue.patch24.95 KBalunyov
#8 Screen Shot 2017-06-01 at 12.56.29 PM.png77.28 KBgg24
#7 2855165-6-D8-deprecated_methods_and_function__fixed_critical_issue.patch14.51 KBalunyov
#3 deprecated_methods_and_function-2855165-3.patch12.63 KBZnak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Znak created an issue. See original summary.

Znak’s picture

Znak CreditAttribution: Znak commented
Issue summary: View changes
Znak’s picture

Znak CreditAttribution: Znak commented
Assigned: Znak » Unassigned
Status: Needs work » Needs review
FileSize
deprecated_methods_and_function-2855165-3.patch12.63 KB

Patch for fix this. Please, check up.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Version: 8.x-1.0-alpha0 » 8.x-1.x-dev

Can you please link the change notices for each of the issues in the description?

Also all changes are to dev.

Status: Needs review » Needs work

The last submitted patch, 3: deprecated_methods_and_function-2855165-3.patch, failed testing.

alunyov’s picture

alunyov CreditAttribution: alunyov at FFW commented
Status: Needs work » Needs review

Hello Guys,
I have updated patch, because there were two critical issues were causing failing tests:
1st is about loading entity form display
2nd is about the way how drupal_render_children() was replaced
Additionally I have replaced \Drupal::database()->query() (where SELECT is called) with \Drupal::database()->select(), since that is more Drupal way.
Please review the patch,

alunyov’s picture

alunyov CreditAttribution: alunyov at FFW commented
FileSize
2855165-6-D8-deprecated_methods_and_function__fixed_critical_issue.patch14.51 KB

And here is patch to comment above (#6)

gg24’s picture

gg24 CreditAttribution: gg24 as a volunteer and at QED42 commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2017-06-01 at 12.56.29 PM.png77.28 KB

Testing steps are as follows:-

  1. Enabled Captcha Module.
  2. Enabled node_edit_form captcha point.
  3. Changed captcha settings accordingly.
  4. Created a new anonymous user.
  5. Added edit and add node permission to it.
  6. Tried creating a new node and tried editing the node from this particular user.
  7. If i put wrong captcha, it gives error to me.
  8. Everything works as expected.

Attaching screenshot for the captcha here too. #7 Patch works as expected. Issuing RTBC to this.

Thanks!

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
Status: Reviewed & tested by the community » Needs review

Avoid static method call inside Class method, use dependency injection instead.

alunyov’s picture

alunyov CreditAttribution: alunyov at FFW commented
FileSize
2855165-10-D8-deprecated_methods_and_function__fixed_critical_issue.patch24.95 KB

I have updated patch. Added dependency injections to Captcha, CaptchaCachedSettingsSubscriber, CaptchaExamplesForm, CaptchaPointForm and CaptchaSettingsForm classes even that was not requested initially.
@gg24, @bapi_22 feel free to check it now.
P.S. locally tests are run without issues.

  • elachlan committed bdd0e74 on 8.x-1.x authored by alunyov 
    Issue #2855165 by alunyov, Znak, gg24, bapi_22: Deprecated methods and...
elachlan’s picture

elachlan CreditAttribution: elachlan commented

I've committed the changes so the patches aren't so massive. So it should be easier to tweak if necessary.

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
Status: Needs review » Needs work

Hi alunyov,

Looks good Now.
As REQUEST_TIME is deprecated, so try to use \Drupal::time()->getRequestTime() instead.

Thanks

alunyov’s picture

alunyov CreditAttribution: alunyov at FFW commented
FileSize
2855165-14-D8-deprecated_methods_and_function__replaced_REQUEST_TIME.patch2.99 KB

Hey bapi_22,
Here is new patch to replace deprecated REQUEST_TIME. Tests run locally fine.

alunyov’s picture

alunyov CreditAttribution: alunyov at FFW commented
Status: Needs work » Needs review

Marking the issue as 'Needs review'

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
Status: Needs review » Reviewed & tested by the community

#14 Looks good
+1 to RTBC

  • elachlan committed f3201a7 on 8.x-1.x authored by alunyov 
    Issue #2855165 by alunyov, Znak, gg24, elachlan: Deprecated methods and...
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.