Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker created an issue. See original summary.

miro_dietiker’s picture

Issue tags: +Usability
Ginovski’s picture

Ordered alphabetically

Status: Needs review » Needs work

The last submitted patch, 3: order_behavior_plugins-2854354-3.patch, failed testing.

Ginovski’s picture

Ordered alphabetically in paragraphs.
Maybe we can also make an order function for the enabled plugins to show first, then all the others (alphabetically by default)?

Status: Needs review » Needs work

The last submitted patch, 5: order_behavior_plugins-2854354-5.patch, failed testing.

johnchque’s picture

Not sure if would be better to sort them when getting all the plugins. So we can just use them already sorted.

Ginovski’s picture

Fixed tests.
(#5) Still can make an order function for the enabled plugins to show first, then all the others (alphabetically by default)

@yongt9412, you mean in the BehaviorManager?

Primsi’s picture

IMHO moving the enabled plugins on top would make the list "unpredictable" for the user. Especially if we have a lot of them, that list would change per type. This means that it would be harder for the user to scan through.

toncic’s picture

I think proposal from #5 is OK. You have behaviors in some order and when you enable one, that one is moving on the top and all other stayed on the same position.

miro_dietiker’s picture

Status: Needs review » Needs work

Needs a reroll.

pivica’s picture

Patch rerolled.

Not fully sure about this because we are ordering plugins currently by array key. It's more consistent now but still a bit weird. If the main goal of this issue is to order plugins alphabetically so users can more easily visually locate a plugin when there is a lot of plugins then maybe we should order plugins by their label and not id?

Screenshot before and after a patch:

It's better but still a bit weird because plugins ids and labels can be different.

Status: Needs review » Needs work

The last submitted patch, 12: order_behavior_plugins-2854354-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

miro_dietiker’s picture

Yeah totally, if we order it, it should be by plugin label.

pivica’s picture

Status: Needs work » Needs review
FileSize
3.71 KB
2.3 KB

Fixed tests and changed sorting by plugin label.

  • miro_dietiker committed 05d9d53 on 8.x-1.x authored by pivica
    Issue #2854354 by Ginovski, pivica, miro_dietiker: Order behavior...
miro_dietiker’s picture

Title: Order behavior plugins » Order behavior plugins in UI
Status: Needs review » Fixed

That's interestingly funny... I thought we change the sequence in the admin UI, then we coincidentally also change the sequence for plugin processing and class output...

It seems the sequence is persisted.... on settings save and that is used for plugin execution sequence.
So that's a follow-up to define a more technical plugin order.
Created #2931763: Guarantee Behavior Plugin execution sequence

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.