Correct typo of "Retrive" at :

// Retrive the table name and schema
    $table_info = $this->getPrefixInfo($table_name, $add_prefix);
CommentFileSizeAuthor
#7 Fixed.png9.63 KBrenatog
#4 typo_in_schema_inc_file-2851725-4.patch8.65 KBriddhi.addweb
#2 2851725-2.patch2 KBtameeshb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jigar.addweb created an issue. See original summary.

tameeshb’s picture

tameeshb CreditAttribution: tameeshb at Google Summer of Code commented
Status: Active » Needs review
FileSize
2851725-2.patch2 KB

Found total 4 occurrences of the same typo

tameeshb@imt3rabyt3 /v/w/h/drupal7> grep -r 'Retrive' .
./includes/database/pgsql/database.inc:   * Retrive a the next id in a sequence.
./includes/database/pgsql/database.inc:    // Retrive the name of the sequence. This information cannot be cached
./includes/database/pgsql/database.inc:    // Retrive the next id. We know this will be as high as we want it.
./includes/database/schema.inc:    // Retrive the table name and schema
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Related issues: +#2622992: Run a spellchecker against core and fix all the errors in comments
riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented
Assigned: riddhi.addweb » Unassigned
FileSize
typo_in_schema_inc_file-2851725-4.patch8.65 KB

Here is patch some other typo solved as well.

Dinesh18’s picture

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented
Status: Needs review » Fixed

I have tested the patch #4 at my end and it fixes the spelling mistake.
Works as expected.

riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Fixed » Reviewed & tested by the community

@Dinesh: Let maintainer commit the patch, before that you cannot make status as "Fixed".

If you have tested patch you can make status as "RTBC" and let maintainer commit the patch and provide respective credit.

Thanks!

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
FileSize
Fixed.png9.63 KB

Hi guys.

I was analyzing it and it really makes sense. Good catch.

Good Work.

Regards.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Title: Typo in schema.inc file » Fix typos in various code comments in the includes directory
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

I reverted or changed a couple of these on commit, though:

diff --git a/includes/ajax.inc b/includes/ajax.inc
index f059209..683d176 100644
--- a/includes/ajax.inc
+++ b/includes/ajax.inc
@@ -252,7 +252,7 @@ function ajax_render($commands = array()) {
       $items[$type] = $function();
       drupal_alter($type, $items[$type]);
       // @todo Inline CSS and JS items are indexed numerically. These can't be
-      //   reliably diffed with array_diff_key(), since the number can change
+      //   reliably differed with array_diff_key(), since the number can change
       //   due to factors unrelated to the inline content, so for now, we strip
       //   the inline items from Ajax responses, and can add support for them
       //   when drupal_add_css() and drupal_add_js() are changed to use a hash

I reverted this change, since the original ("diffed") was actually correct here.

diff --git a/includes/database/pgsql/database.inc b/includes/database/pgsql/database.inc
index c5ca403..fb3d0ab 100644
--- a/includes/database/pgsql/database.inc
+++ b/includes/database/pgsql/database.inc
@@ -11,7 +11,7 @@
  */
 
 /**
- * The name by which to obtain a lock for retrieve the next insert id.
+ * The name by which to obtain a lock for retrieving the next insert id.
  */
 define('POSTGRESQL_NEXTID_LOCK', 1000);

I fixed that additional grammatical error on the same line.

diff --git a/includes/database/pgsql/database.inc b/includes/database/pgsql/database.inc
index 4c9637b..c5ca403 100644
--- a/includes/database/pgsql/database.inc
+++ b/includes/database/pgsql/database.inc
@@ -175,7 +175,7 @@ class DatabaseConnection_pgsql extends DatabaseConnection {
   }
 
   /**
-   * Retrieve a the next id in a sequence.
+   * Retrieve the next id in a sequence.
    *
    * PostgreSQL has built in sequences. We'll use these instead of inserting
    * and updating a sequences table.

Same here - I fixed that additional grammatical error on the same line.

  • David_Rothstein committed 9480662 on 7.x 
    Issue #2851725 by Jigar.addweb, tameeshb: Fix typos in various code...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.